clears

[larshp]

No description provided.

[Copilot]

Pull request overview

This PR tightens SSH client secret-handling and host-key verification context by (a) binding host-key trust decisions to the connection endpoint (host/port) and (b) aggressively clearing credential/key material from long-lived objects after use, close, or disconnect.

Changes:

• Extend zif_oassh_host_verifier~verify to receive iv_host/iv_port and thread those through zcl_oassh → zcl_oassh_transport.
• Add best-effort “clear secrets” APIs (clear_credentials, clear_secrets, clear_pending_keys) and call them on close/disconnect and key lifecycle boundaries.
• Add coverage for secret-clearing behavior and add an RSA public-exponent size guard in verification.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/zcl_oassh.clas.testclasses.abap	Adds tests for clearing secrets on close( ) and updates constructors with iv_host/iv_port.
src/zcl_oassh.clas.abap	Threads host/port to transport; clears credentials/secrets on close, disconnect, and post-auth start.
src/zcl_oassh_transport.clas.testclasses.abap	Tests endpoint forwarding to the host verifier and transport secret clearing.
src/zcl_oassh_transport.clas.abap	Stores host/port, passes them into verifier callback, and centralizes clearing of credentials/key material.
src/zcl_oassh_packet.clas.testclasses.abap	Adds unit test asserting packet crypto material is cleared.
src/zcl_oassh_packet.clas.abap	Introduces clear_secrets (encrypt/decrypt cleanup) and reuses it during rekey.
src/platform/zif_oassh_host_verifier.intf.abap	Extends verifier API to include host/port for endpoint-specific trust decisions.
src/crypto/zcl_oassh_rsa.clas.testclasses.abap	Adds a test for rejecting oversized RSA public exponent inputs.
src/crypto/zcl_oassh_rsa.clas.abap	Adds an exponent-length ceiling before expensive exponentiation.
src/crypto/zcl_oassh_ctr.clas.testclasses.abap	Adds unit test for CTR secret clearing.
src/crypto/zcl_oassh_ctr.clas.abap	Adds clear_secrets to drop schedule/counter/keystream state.
src/crypto/zcl_oassh_chachapoly.clas.testclasses.abap	Adds unit test for chachapoly key clearing.
src/crypto/zcl_oassh_chachapoly.clas.abap	Adds clear_secrets and clears a derived Poly1305 key buffer after use.
README.md	Documents host/port binding for host-key verification.
integration/socket.mjs	Passes iv_host/iv_port into ABAP client construction for integration runs.
examples/zoassh_example_sftp.prog.abap	Updates example verifier guidance to include host/port + key association.
examples/zoassh_example_exec.prog.abap	Updates example verifier guidance to include host/port + key association.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.