Repository navigation
Fail tests if the bundled data has no frameworks or objections - #31
Merged
Merged
Conversation
The book repo builds data/book.json.br from a gitignored paraphrase file. Built without it, the data ships with empty frameworks and objections, and handle_objection plus the framework answers quietly lose their content while every existing test still passes. The book repo now refuses that build (open-and-async-book#2116); this is the backstop in this repo, so a hand-copied refresh can't ship without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
data/book.json.bris built in the book repo from a paraphrase file that's gitignored there. Built without that file, the data ships with emptyframeworksandobjections.handle_objectionand the framework answers then quietly lose their content, and every existing test still passes.The book repo now refuses that build. This test is the backstop here, so a hand-copied data refresh can't ship without them.
What
A test in
test/data.test.jsasserts thatbook.frameworksandbook.objectionsare non-empty, and that frameworks exist for each role (any,manager,ic).Verified
npm test: all 45 tests pass on the current data.book.json.brwith frameworks and objections emptied. The new test failed withbook.frameworks is empty. I restored the real file before committing.Tests only. No release needed.
🤖 Generated with Claude Code