95 setup functions

[yolile]

• component_setup_charts.py -> charts.py
• component_setup_metadata_from_registry.py -> registry.py
• component_setup_usability.py, component_setup_red_flags.py -> usability.py

[codecov]

Codecov Report

❌ Patch coverage is 0% with 168 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.68%. Comparing base (d5fc488) to head (315feec).

Files with missing lines	Patch %	Lines
ocdskingfishercolab/indicators/__init__.py	0.00%	77 Missing ⚠️
ocdskingfishercolab/usability.py	0.00%	40 Missing ⚠️
ocdskingfishercolab/charts.py	0.00%	32 Missing ⚠️
ocdskingfishercolab/registry.py	0.00%	19 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #96       +/-   ##
===========================================
- Coverage   79.49%   46.68%   -32.82%     
===========================================
  Files           7       11        +4     
  Lines         239      407      +168     
===========================================
  Hits          190      190               
- Misses         49      217      +168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jpmckinney]

Just a reminder that is_relevant was refactored in the notebooks.

[yolile]

Aha, I'm using your PR's version https://github.com/open-contracting/notebooks-ocds/blob/01e19bf8f3749516085c096d674f6cb993229388/component_setup_usability.py#L91

[jpmckinney]

I think relevant_rules as a global might be better, so it can be reused if needed

[jpmckinney]

We'll need something like this in pyproject.toml:

[tool.setuptools.package-data]
kingfishercolab = ["indicators/*.json"]

Unless we move the JSON to data-support per open-contracting/notebooks-ocds#106

[jpmckinney]

For the JSON Schema lints, we can edit standard-maintenance-scripts to ignore it, either in ocds_schema_exceptions or excluded_repo_name. Or we can update the shared lint.yml to accept configuration instead of editing those.

Edit: You can now exclude files in lint.yml by adding:

    with:
      ocds-schema-exceptions: my-schema.json

[yolile]

Edit: You can now exclude files in lint.yml by adding:

Ok, still failing with

ocds-schema-exceptions: ocdskingfishercolab/indicators/indicators.schema.json

[jpmckinney]

Just this: indicators.schema.json

[jpmckinney]

@yolile Lints now pass.