Skip to content

standardize Content-Disposition header formatting across controllers #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solverat merged 1 commit into from
Jun 30, 2026
Merged

standardize Content-Disposition header formatting across controllers #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Controller/Admin/Asset/AssetController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,7 @@ public function downloadAction(Request $request): StreamedResponse
fpassthru($stream);
}, 200, [
'Content-Type' => $asset->getMimeType(),
'Content-Disposition' => sprintf('attachment; filename: "%s"', $asset->getFilename()),
'Content-Disposition' => sprintf('attachment; filename="%s"', $asset->getFilename()),
'Content-Length' => $asset->getFileSize(),
]);
}
Expand Down
4 changes: 2 additions & 2 deletions src/Controller/Admin/DataObject/ClassController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ public function exportClassAction(Request $request): Response

$response = new Response($json);
$response->headers->set('Content-type', 'application/json');
$response->headers->set('Content-Disposition', 'attachment; filename: "class_' . $class->getName() . '_export.json"');
$response->headers->set('Content-Disposition', 'attachment; filename="class_' . $class->getName() . '_export.json"');

return $response;
}
Expand All @@ -661,7 +661,7 @@ public function exportCustomLayoutDefinitionAction(Request $request): Response

$response = new Response($json);
$response->headers->set('Content-type', 'application/json');
$response->headers->set('Content-Disposition', 'attachment; filename: "custom_definition_' . $name . '_export.json"');
$response->headers->set('Content-Disposition', 'attachment; filename="custom_definition_' . $name . '_export.json"');

return $response;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Controller/Admin/DataObject/QuantityValueController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public function unitExportAction(Request $request): Response
$result = $this->service->generateDefinitionJson();
$response = new Response($result);
$response->headers->set('Content-Type', 'application/json');
$response->headers->set('Content-Disposition', 'attachment;filename: "quantityvalue_unit_export.json"');
$response->headers->set('Content-Disposition', 'attachment; filename="quantityvalue_unit_export.json"');

return $response;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Controller/Admin/TranslationController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ public function exportAction(Request $request): Response
$response = new Response("\xEF\xBB\xBF" . $csv);
$response->headers->set('Content-Encoding', 'UTF-8');
$response->headers->set('Content-Type', 'text/csv; charset=UTF-8');
$response->headers->set('Content-Disposition', 'attachment; filename: "export_' . $domain . '_translations.csv"');
$response->headers->set('Content-Disposition', 'attachment; filename="export_' . $domain . '_translations.csv"');
ini_set('display_errors', '0'); //to prevent warning messages in csv

return $response;
Expand Down
Loading