Skip to content

filedevice: Make ArchiveFileDevice::getArchiveFileHandle_ non-const #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MonsterDruide1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

filedevice: Make ArchiveFileDevice::getArchiveFileHandle_ non-const #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dd83c9
filedevice: Make `ArchiveFileDevice::getArchiveFileHandle_` non-const
MonsterDruide1 May 16, 2026
48f55a0
clang-format
MonsterDruide1 May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/filedevice/seadArchiveFileDevice.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class ArchiveFileDevice : public FileDevice
virtual s32 doConvertPathToEntryID_(const SafeString& path);
virtual bool doSetCurrentDirectory_(const SafeString& path);

ArchiveFileHandle* getArchiveFileHandle_(FileHandle* handle) const;
ArchiveFileHandle* getArchiveFileHandle_(FileHandle* handle);
ArchiveFileHandle* constructArchiveFileHandle_(FileHandle* handle) const;

ArchiveRes* mArchive;
Expand Down
3 changes: 1 addition & 2 deletions modules/src/filedevice/seadArchiveFileDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,7 @@ bool ArchiveFileDevice::doGetFileSize_(u32* fileSize, FileHandle* handle)
return true;
}

ArchiveFileDevice::ArchiveFileHandle*
ArchiveFileDevice::getArchiveFileHandle_(FileHandle* handle) const
ArchiveFileDevice::ArchiveFileHandle* ArchiveFileDevice::getArchiveFileHandle_(FileHandle* handle)
{
return reinterpret_cast<ArchiveFileHandle*>(getHandleBaseHandleBuffer_(handle).getBufferPtr());
}
Expand Down
Loading