[ESLint 1/10] Fix warnings

[ShaileshParmar11]

Fixes #. Part of epic #30977.

Stacked PR 1 of 10 — base branch ``. Review after the previous PR in the stack; the diff here contains only the ** changes.

Behavior-preserving lint cleanup. Verified: target rule(s) → 0, no new warnings (git-stash ESLint before/after), 0 new tsc signatures vs baseline. Full approach + caveats in the epic #30977.

🤖 Generated with Claude Code

[greptile-apps]

Too many files changed for review (1889 files, 100 file limit).

[Copilot]

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

[github-actions]

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

• No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

[gitar-bot]

💡 Quality: Non-null assertions replaced with '' fallback in toRef

In CreateMemoryModal.component.tsx toRef now uses a.reference?.id ?? '' and a.reference?.type ?? '' instead of the previous non-null assertions. Behavior is preserved because the source array is pre-filtered to entries with reference?.id && reference?.type, so the '' branch is unreachable today. The fallback is harmless but silently masks the invariant; if the upstream filter is ever removed, empty-string ids/types would be sent to the API. Consider keeping the filter/assertion coupling explicit.

_{Was this helpful? React with 👍 / 👎}

[Copilot]

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

[Copilot]

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

[ShaileshParmar11]

Superseded by 10 stacked, per-rule PRs (#30989–#30998) tracked under epic #30977 — per review feedback that a single 1,400-file PR is not reviewable. Closing this one.

[gitar-bot]

Code Review 👍 Approved with suggestions 1 resolved / 2 findings

Resolves frontend ESLint warnings across multiple rule categories to achieve zero warnings. Consider addressing the non-null assertion fallback in CreateMemoryModal to avoid unexpected empty strings.

💡 Quality: Non-null assertions replaced with '' fallback in toRef

📄 openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/CreateMemoryModal/CreateMemoryModal.component.tsx:420-426

In CreateMemoryModal.component.tsx toRef now uses a.reference?.id ?? '' and a.reference?.type ?? '' instead of the previous non-null assertions. Behavior is preserved because the source array is pre-filtered to entries with reference?.id && reference?.type, so the '' branch is unreachable today. The fallback is harmless but silently masks the invariant; if the upstream filter is ever removed, empty-string ids/types would be sent to the API. Consider keeping the filter/assertion coupling explicit.

✅ 1 resolved

✅ Bug: React keys switched to potentially non-unique values

📄 openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UsersProfile/UserPermissions/UserPermissions.component.tsx:99-113
In UserPermissions.component.tsx the list keys were changed from array indices to rule.name and op (key={rule.name}, key={op}). This improves reconciliation only if those values are unique per list; if a user has duplicate rule names or repeated operations, React will emit duplicate-key warnings and may mis-reconcile rows. This is almost certainly safe for typical permission data, but consider keeping an index suffix (e.g. ${rule.name}-${index}) if uniqueness is not guaranteed.

🤖 Prompt for agents

Code Review: Resolves frontend ESLint warnings across multiple rule categories to achieve zero warnings. Consider addressing the non-null assertion fallback in CreateMemoryModal to avoid unexpected empty strings.

1. 💡 Quality: Non-null assertions replaced with '' fallback in toRef
   Files: openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/CreateMemoryModal/CreateMemoryModal.component.tsx:420-426

   In CreateMemoryModal.component.tsx `toRef` now uses `a.reference?.id ?? ''` and `a.reference?.type ?? ''` instead of the previous non-null assertions. Behavior is preserved because the source array is pre-filtered to entries with `reference?.id && reference?.type`, so the `''` branch is unreachable today. The fallback is harmless but silently masks the invariant; if the upstream filter is ever removed, empty-string ids/types would be sent to the API. Consider keeping the filter/assertion coupling explicit.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact

gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source}