Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion openmetadata-ui/src/main/resources/ui/eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -454,16 +454,20 @@ export default [
},
},

// Test setup files
// Test, spec, and mock files: these contain no user-facing strings, so the
// i18n literal-string rule does not apply to them.
{
files: [
'src/setupTests.js',
'src/**/*.test.{js,jsx,ts,tsx}',
'src/**/*.spec.{js,jsx,ts,tsx}',
'src/**/*.mock.{js,jsx,ts,tsx}',
'src/mocks/**/*.{js,jsx,ts,tsx}',
'playwright/**/*.spec.{js,jsx,ts,tsx}',
],
rules: {
'@typescript-eslint/no-require-imports': 'off',
'i18next/no-literal-string': 'off',
},
},
];
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@

useEffect(() => {
fetchTestCaseSummary();
}, [tableFqn]);

Check warning on line 357 in openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaTable/SchemaTable.component.tsx

View workflow job for this annotation

GitHub Actions / checkstyle

React Hook useEffect has a missing dependency: 'fetchTestCaseSummary'. Either include it or remove the dependency array

Check warning on line 357 in openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaTable/SchemaTable.component.tsx

View workflow job for this annotation

GitHub Actions / checkstyle

React Hook useEffect has a missing dependency: 'fetchTestCaseSummary'. Either include it or remove the dependency array

useEffect(() => {
if (searchText || hasTagFilter) {
Expand Down Expand Up @@ -456,7 +456,7 @@
return prev;
});
},
[]

Check warning on line 459 in openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaTable/SchemaTable.component.tsx

View workflow job for this annotation

GitHub Actions / checkstyle

React Hook useCallback has a missing dependency: 'tableFqn'. Either include it or remove the dependency array

Check warning on line 459 in openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaTable/SchemaTable.component.tsx

View workflow job for this annotation

GitHub Actions / checkstyle

React Hook useCallback has a missing dependency: 'tableFqn'. Either include it or remove the dependency array
);

useSub(
Expand Down Expand Up @@ -665,10 +665,11 @@
key: 'name',
label: (
<span data-testid="sort-alphabetical">
{t('label.alphabetical')} (A → Z)
{t('label.alphabetical')} {t('label.a-to-z-order')}
</span>
),
icon:
// eslint-disable-next-line i18next/no-literal-string -- decorative checkmark glyph
sortBy === 'name' ? <span className="text-primary">✓</span> : null,
},
{
Expand All @@ -680,6 +681,7 @@
),
icon:
sortBy === 'ordinalPosition' ? (
// eslint-disable-next-line i18next/no-literal-string -- decorative checkmark glyph
<span className="text-primary">✓</span>
) : null,
},
Expand Down Expand Up @@ -769,7 +771,7 @@
</div>
);
},
[tableConstraints, searchText, editDisplayNamePermission]

Check warning on line 774 in openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaTable/SchemaTable.component.tsx

View workflow job for this annotation

GitHub Actions / checkstyle

React Hook useCallback has missing dependencies: 'handleEditDisplayNameClick' and 't'. Either include them or remove the dependency array

Check warning on line 774 in openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaTable/SchemaTable.component.tsx

View workflow job for this annotation

GitHub Actions / checkstyle

React Hook useCallback has missing dependencies: 'handleEditDisplayNameClick' and 't'. Either include them or remove the dependency array
);

const renderDataQuality = useCallback(
Expand Down Expand Up @@ -896,7 +898,7 @@
render: renderDataQuality,
},
],
[

Check warning on line 901 in openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaTable/SchemaTable.component.tsx

View workflow job for this annotation

GitHub Actions / checkstyle

React Hook useMemo has missing dependencies: 'handleColumnClick' and 't'. Either include them or remove the dependency array

Check warning on line 901 in openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaTable/SchemaTable.component.tsx

View workflow job for this annotation

GitHub Actions / checkstyle

React Hook useMemo has missing dependencies: 'handleColumnClick' and 't'. Either include them or remove the dependency array
tableFqn,
deleted,
editTagsPermission,
Expand Down Expand Up @@ -976,7 +978,7 @@
});
},
}),
[searchText, handlePageChange, setFilters]

Check warning on line 981 in openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaTable/SchemaTable.component.tsx

View workflow job for this annotation

GitHub Actions / checkstyle

React Hook useMemo has a missing dependency: 't'. Either include it or remove the dependency array

Check warning on line 981 in openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaTable/SchemaTable.component.tsx

View workflow job for this annotation

GitHub Actions / checkstyle

React Hook useMemo has a missing dependency: 't'. Either include it or remove the dependency array
);

const paginationProps = useMemo(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

import { BadgeWithIcon, Typography } from '@openmetadata/ui-core-components';
import { Cube01, Database01, Users01 } from '@untitledui/icons';
import { useTranslation } from 'react-i18next';

const EMPTY_VALUE_INDICATOR = '-';

Expand All @@ -21,6 +22,8 @@ interface DomainTypeChipProps {
}

export const DomainTypeChip = ({ domainType }: DomainTypeChipProps) => {
const { t } = useTranslation();

switch (domainType) {
case 'Consumer-aligned':
return (
Expand All @@ -29,7 +32,7 @@ export const DomainTypeChip = ({ domainType }: DomainTypeChipProps) => {
iconLeading={Users01}
size="sm"
type="color">
Consumer-aligned
{t('label.consumer-aligned')}
</BadgeWithIcon>
);
case 'Source-aligned':
Expand All @@ -39,7 +42,7 @@ export const DomainTypeChip = ({ domainType }: DomainTypeChipProps) => {
iconLeading={Cube01}
size="sm"
type="color">
Source-aligned
{t('label.source-aligned')}
</BadgeWithIcon>
);
case 'Aggregate':
Expand All @@ -49,7 +52,7 @@ export const DomainTypeChip = ({ domainType }: DomainTypeChipProps) => {
iconLeading={Database01}
size="sm"
type="color">
Aggregate
{t('label.aggregate')}
</BadgeWithIcon>
);
default:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

useEffect(() => {
entityType && getResourceLimit(entityType);
}, [entityType]);

Check warning on line 36 in openmetadata-ui/src/main/resources/ui/src/components/Entity/EntityVersionTimeLine/EntityVersionTimeLine.tsx

View workflow job for this annotation

GitHub Actions / checkstyle

React Hook useEffect has a missing dependency: 'getResourceLimit'. Either include it or remove the dependency array

Check warning on line 36 in openmetadata-ui/src/main/resources/ui/src/components/Entity/EntityVersionTimeLine/EntityVersionTimeLine.tsx

View workflow job for this annotation

GitHub Actions / checkstyle

React Hook useEffect has a missing dependency: 'getResourceLimit'. Either include it or remove the dependency array

const { configuredLimit: { maxVersions } = { maxVersions: -1 } } =
resourceLimit[entityType ?? ''] ?? {};
Expand Down Expand Up @@ -73,25 +73,25 @@
</Tooltip>
<div className="version-pricing-reached">
<Typography.Title className="font-medium" level={4}>
Unlock all of your version history
{t('label.unlock-all-of-your-version-history')}
</Typography.Title>
<Typography.Text className="text-grey-muted font-normal">
Upgrade to paid plan for access to all of your version history.
{t('message.upgrade-to-paid-plan-for-version-history')}
</Typography.Text>

<Button
block
className="m-t-lg"
href="/settings/billing/plans"
type="primary">
See Upgrade Options
{t('label.see-upgrade-options')}
</Button>
</div>
</>
) : null}
</div>
);
}, [versionList, currentVersion, versionHandler]);
}, [versionList, currentVersion, versionHandler, t]);

Check warning on line 94 in openmetadata-ui/src/main/resources/ui/src/components/Entity/EntityVersionTimeLine/EntityVersionTimeLine.tsx

View workflow job for this annotation

GitHub Actions / checkstyle

React Hook useMemo has a missing dependency: 'maxVersions'. Either include it or remove the dependency array

Check warning on line 94 in openmetadata-ui/src/main/resources/ui/src/components/Entity/EntityVersionTimeLine/EntityVersionTimeLine.tsx

View workflow job for this annotation

GitHub Actions / checkstyle

React Hook useMemo has a missing dependency: 'maxVersions'. Either include it or remove the dependency array

return (
<Drawer
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import {
import { avatarCanvas, colorFor, iconCanvas } from './nodeCanvas';
import { NodeType } from './types';

const DISCLOSURE_ARROW = '▸';

const TYPE_LABEL_KEY: Record<NodeType, string> = {
domain: 'label.domain',
product: 'label.data-product',
Expand Down Expand Up @@ -123,7 +125,7 @@ const KnowledgeGraph3DLegend: FC = () => {
<span
className="tw:ml-auto tw:text-xs tw:opacity-60 tw:transition-transform"
style={{ transform: isOpen ? 'rotate(90deg)' : 'none' }}>
{DISCLOSURE_ARROW}
</span>
</button>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,9 @@ const RunHistoryDrawer: FC<RunHistoryDrawerProps> = ({
{runLabel}
</div>
<div className="tw:text-xs tw:text-tertiary">
{run.startedAt} ({getUtcOffsetLabel()}) &middot;{' '}
{run.startedAt}{' '}
{/* eslint-disable-next-line i18next/no-literal-string -- punctuation separators around UTC offset */}
({getUtcOffsetLabel()}) &middot;{' '}
{t('message.ran-for-duration', { duration: run.duration })}
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,11 @@ const ExpressionCodeCell = ({
</div>
<div className="bulk-edit-code-editor-foot">
<span className="bulk-edit-code-editor-hint">
{/* eslint-disable-next-line i18next/no-literal-string -- keyboard shortcut glyph */}
<span className="bulk-edit-code-editor-kbd">⌘↵</span>{' '}
{t('label.save').toLowerCase()}
{' · '}
{/* eslint-disable-next-line i18next/no-literal-string -- keyboard key name */}
<span className="bulk-edit-code-editor-kbd">Esc</span>{' '}
{t('label.cancel').toLowerCase()}
</span>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import Icon from '@ant-design/icons';
import { Header } from 'antd/lib/layout/layout';
import classNames from 'classnames';
import { useTranslation } from 'react-i18next';
import { Link } from 'react-router-dom';
import { useLimitStore } from '../../../context/LimitsProvider/useLimitsStore';
import { useTourProvider } from '../../../context/TourProvider/TourProvider';
Expand All @@ -21,6 +22,7 @@ import { ReactComponent as WarningIcon } from './../../../assets/svg/ic-warning-
import './limit-banner.less';

export const LimitBanner = () => {
const { t } = useTranslation();
const { bannerDetails, setBannerDetails } = useLimitStore();
const { isTourPage, isTourOpen } = useTourProvider();

Expand All @@ -44,8 +46,10 @@ export const LimitBanner = () => {
{bannerDetails?.subheader}
<>
{' '}
Learn more about{' '}
<Link to="/settings/billing/plans">plans and pricing.</Link>
{t('label.learn-more-about')}{' '}
<Link to="/settings/billing/plans">
{t('label.plans-and-pricing')}
</Link>
</>
</p>
</div>
Expand Down
Loading
Loading