-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix(playwright): stabilize shared AUT state and test oracles #31788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
harshach
wants to merge
65
commits into
main
Choose a base branch
from
fix/nightly-e2e-stability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,221
−447
Draft
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
ebe42dc
fix(playwright): fixed AgentLogStream flakiness
Rohit0301 526fa79
Fixes #31768: keep live log auto-follow on after a hand-made resume
aniketkatkar97 c1feeb5
test(playwright): stabilize auth and glossary asset checks
harshach 492b571
test(playwright): isolate shared AUT state
harshach f56ec36
Merge remote-tracking branch 'origin/pr-31764' into test/aut-31788-5919
harshach e52791b
Merge remote-tracking branch 'origin/pr-31769' into test/aut-31788-5919
harshach 45fb5f8
test(playwright): apply AUT handover timeout budget
harshach cfedede
test(playwright): format IPv6 webhook receiver URLs
harshach c4d198d
test(playwright): format IPv6 webhook receiver URLs
harshach 45b0a6f
test(ui): seed optional following widget
harshach 1394f62
test(ui): seed optional following widget
harshach 91c0009
test(playwright): stabilize async UI state
harshach f4ece72
test(playwright): stabilize async UI state
harshach 6d57d0f
test(playwright): observe eager glossary asset fetch
harshach 3ffde4c
test(playwright): observe eager glossary asset fetch
harshach 3410834
test(playwright): wait for glossary search index
harshach a5e0c2d
test(playwright): wait for glossary search index
harshach e2e1d83
test(playwright): persist following widget before navigation
harshach cf3a489
test(playwright): persist following widget before navigation
harshach 74a08a6
test(playwright): fix strict AUT failures
harshach aec4445
test(playwright): fix strict AUT failures
harshach 5bc06b5
fix(data-access): resolve current assignee server-side
harshach 3db3b2b
test(data-access): cover current assignee filter
harshach f8044a5
Stop IngestionLogStreamLive racing the connector's quiet phase
aniketkatkar97 aed4224
test(playwright): bound certification popover close race
harshach 2fe87f9
test(playwright): bound certification popover close race
harshach 701ba2d
test(playwright): match traced application contracts
harshach 646e22d
test(playwright): match traced application contracts
harshach 7796fff
test(playwright): wait for routed fallback state
harshach 514f22b
test(playwright): wait for routed fallback state
harshach cb416b6
test(playwright): wait for certification controls
harshach 13ec310
test(playwright): wait for certification controls
harshach ef43d64
style(playwright): format search indexing route check
harshach 3b935bc
style(playwright): format search indexing route check
harshach 76cc03b
test(playwright): remove full-lane timing races
harshach 6da9f16
test(playwright): verify exact indexed entity
harshach 59d23f5
test(playwright): remove full-lane timing races
harshach 4a2a438
test(playwright): verify exact indexed entity
harshach 5b3cac3
test(playwright): avoid pipeline status race
harshach 340a1f9
test(playwright): avoid pipeline status race
harshach 4b4fb86
test(playwright): fix focused auth and invalid-route checks
harshach 0212e1c
test(playwright): fix focused auth and invalid-route checks
harshach fb51632
test(playwright): poll deleted document search exactly
harshach e0a77d1
test(playwright): poll deleted document search exactly
harshach f923065
test(playwright): reveal late landing widgets
harshach 13914b1
test(playwright): reveal late landing widgets
harshach fd71a12
Merge remote-tracking branch 'origin/main' into fix/nightly-e2e-stabi…
harshach 598642d
test(playwright): fix exact search and toast races
harshach 5770cec
test(playwright): isolate column search fixtures
harshach 91ce3d8
Merge remote-tracking branch 'origin/main' into fix/nightly-e2e-stabi…
harshach 3b8846f
Merge complete AUT stability source
harshach 58f9128
Merge remote-tracking branch origin/main into fix/nightly-e2e-stability
harshach 5570d32
test(playwright): preserve data product identity
harshach 6b457aa
test(playwright): serialize shared service versions
harshach 828130b
test(playwright): seed bot auth on stable origin
harshach 7452f93
fix(ui): ignore stale explore facet responses
harshach f78d607
test(playwright): await exact explore facet searches
harshach 383d8b9
test(playwright): preserve shared governance fixtures
harshach 9f6c250
test(playwright): isolate tenant search settings
harshach 487abc3
fix(ui): preserve relevance for typed mentions
harshach 1fc9b90
test(playwright): stabilize full-suite state
harshach 4bc978a
test(playwright): handle early admin signin redirects
harshach f8ac430
test(playwright): initialize fresh auth storage safely
harshach b35160d
test(ui): satisfy quick filter formatting rule
harshach cb0c38d
test(playwright): surface rejected data product assets
harshach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Quality: Tautological assertion in eager-fetch pagination branch
In ContextCenterArticles.spec.ts the
if (initialCardCount > ARTICLE_LIST_PAGE_SIZE)branch assertsexpect(initialCardCount).toBeGreaterThan(ARTICLE_LIST_PAGE_SIZE), which is guaranteed true by the branch condition itself and verifies nothing about pagination. In this case the test provides no real coverage that additional pages were fetched. Consider asserting a concrete post-condition (e.g. that the card count exceeds one page's worth of items, or that at least one paginated fetch was observed) so the branch still validates the eager-fetch behavior described in the comment.Was this helpful? React with 👍 / 👎