test(ui): suppress landing welcome banner at source, remove dismiss helpers

openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts

@@ -30,7 +30,6 @@ import { REACTION_EMOJIS, reactOnFeedCard } from '../../utils/activityFeed';
 import { performAdminLogin } from '../../utils/admin';
 import {
   redirectToHomePage,
-  removeLandingBanner,
   uuid,
   visitOwnProfilePage,
 } from '../../utils/common';
@@ -168,7 +167,6 @@ test.describe('FeedWidget on landing page', () => {
         try {
           // Set persona as default
           await redirectToHomePage(adminPage);
-          await removeLandingBanner(adminPage);
           await waitForAllLoadersToDisappear(adminPage);
           await setUserDefaultPersona(adminPage, testPersona.data.displayName);
 
@@ -199,7 +197,6 @@ test.describe('FeedWidget on landing page', () => {
           }
 
           await redirectToHomePage(adminPage);
-          await removeLandingBanner(adminPage);
           await waitForAllLoadersToDisappear(adminPage);
         } finally {
           await adminPage.close();
@@ -224,7 +221,6 @@ test.describe('FeedWidget on landing page', () => {
   test.beforeEach(async ({ page }) => {
     await adminUser.login(page);
     await redirectToHomePage(page);
-    await removeLandingBanner(page);
     await waitForAllLoadersToDisappear(page);
   });
 

openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/CuratedAssets.spec.ts

@@ -16,7 +16,7 @@
 import { UserClass } from '../../support/user/UserClass';
 import { performAdminLogin } from '../../utils/admin';
 import { selectOption } from '../../utils/advancedSearch';
-import { redirectToHomePage, removeLandingBanner } from '../../utils/common';
+import { redirectToHomePage } from '../../utils/common';
 import {
   addCuratedAssetPlaceholder,
   CURATED_ASSETS_WIDGET_KEY,
@@ -63,7 +63,7 @@
 
 const test = base.extend<{ page: Page }>({
   page: async ({ browser }, use) => {
     const page = await browser.newPage();
     await adminUser.login(page);
     await use(page);
     await page.close();
@@ -101,7 +101,6 @@
 
     await setUserDefaultPersona(page, persona.responseData.displayName);
     await redirectToHomePage(page);
-    await removeLandingBanner(page);
 
     await page.getByTestId('sidebar-toggle').click();
   });
@@ -188,7 +187,6 @@
       ).toBeVisible();
 
       await redirectToHomePage(page);
-      await removeLandingBanner(page);
 
       await waitForAllLoadersToDisappear(page, 'entity-list-skeleton');
 
@@ -387,7 +385,6 @@
     // Wait for auto-save to complete before navigating
 
     await redirectToHomePage(page);
-    await removeLandingBanner(page);
 
     await waitForAllLoadersToDisappear(page, 'entity-list-skeleton');
 
@@ -503,7 +500,6 @@
 
     // Navigate to landing page to verify widget
     await redirectToHomePage(page);
-    await removeLandingBanner(page);
 
     await waitForAllLoadersToDisappear(page, 'entity-list-skeleton');
 
@@ -646,7 +642,6 @@
 
     // Navigate to landing page to verify widget
     await redirectToHomePage(page);
-    await removeLandingBanner(page);
 
     await waitForAllLoadersToDisappear(page, 'entity-list-skeleton');
 
@@ -685,7 +680,6 @@
     await page.locator('[data-testid="save-button"]').click();
 
     await redirectToHomePage(page);
-    await removeLandingBanner(page);
 
     // Verify placeholder is not visible when no widget is configured
     await expect(

openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/LandingPageWidgets/DomainDataProductsWidgets.spec.ts

@@ -20,7 +20,7 @@
 import { PersonaClass } from '../../../support/persona/PersonaClass';
 import { UserClass } from '../../../support/user/UserClass';
 import { performAdminLogin } from '../../../utils/admin';
-import { redirectToHomePage, removeLandingBanner } from '../../../utils/common';
+import { redirectToHomePage } from '../../../utils/common';
 import {
   addAndVerifyWidget,
   setUserDefaultPersona,
@@ -59,7 +59,7 @@
 
 const test = base.extend<{ page: Page }>({
   page: async ({ browser }, use) => {
     const page = await browser.newPage();
     await adminUser.login(page);
     await use(page);
     await page.close();
@@ -95,7 +95,6 @@
   test.slow(); // Slow Test
   test.beforeEach(async ({ page }, testInfo) => {
     await redirectToHomePage(page, false);
-    await removeLandingBanner(page);
     await waitForAllLoadersToDisappear(page).catch(() => undefined);
 
     if (testInfo.title !== 'Assign Widgets') {
@@ -112,7 +111,6 @@
         dataProduct.responseData.id ?? ''
       );
       await redirectToHomePage(page, false);
-      await removeLandingBanner(page);
       await waitForAllLoadersToDisappear(page).catch(() => undefined);
     }
   });
@@ -134,7 +132,6 @@
 
   test('Verify Widgets are having 0 count initially', async ({ page }) => {
     await redirectToHomePage(page, false);
-    await removeLandingBanner(page);
     await waitForAllLoadersToDisappear(page).catch(() => undefined);
 
     await verifyWidgetCountOnCurrentPage(

openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/CustomizeLandingPage.spec.ts

@@ -15,11 +15,7 @@
 import { PersonaClass } from '../../support/persona/PersonaClass';
 import { UserClass } from '../../support/user/UserClass';
 import { performAdminLogin } from '../../utils/admin';
-import {
-  redirectToHomePage,
-  removeLandingBanner,
-  toastNotification,
-} from '../../utils/common';
+import { redirectToHomePage, toastNotification } from '../../utils/common';
 import {
   checkAllDefaultWidgets,
   navigateToCustomizeLandingPage,
@@ -98,7 +94,7 @@
     // the stock layout instead of the persona's customizable one.
     void persona;
 
     const adminPage = await browser.newPage();
     await testUser.login(adminPage);
     await use(adminPage);
     await adminPage.close();
@@ -339,7 +335,6 @@
 
           await saveCustomizeLayoutPage(adminPage);
           await redirectToHomePage(adminPage, false);
-          await removeLandingBanner(adminPage);
           await waitForAllLoadersToDisappear(adminPage).catch(() => undefined);
 
           await waitForLandingPageWidget(adminPage, 'KnowledgePanel.MyData');

openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/CustomizeWidgets.spec.ts

@@ -22,11 +22,7 @@
 import { UserClass } from '../../support/user/UserClass';
 import { insertActivityEventForTest } from '../../utils/activityAPI';
 import { performAdminLogin } from '../../utils/admin';
-import {
-  getApiContext,
-  redirectToHomePage,
-  removeLandingBanner,
-} from '../../utils/common';
+import { getApiContext, redirectToHomePage } from '../../utils/common';
 import {
   addAndVerifyWidget,
   removeAndVerifyWidget,
@@ -127,7 +123,7 @@
     // the stock layout instead of the persona's customizable one.
     void persona;
 
     const page = await browser.newPage();
     await testUser.login(page);
     await use(page);
     await page.close();
@@ -238,7 +234,6 @@
 
 test.beforeEach(async ({ page }) => {
   await redirectToHomePage(page);
-  await removeLandingBanner(page);
   await waitForAllLoadersToDisappear(page);
   await waitForAllLoadersToDisappear(page, 'entity-list-skeleton');
 });

openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/Tour.spec.ts

@@ -173,7 +173,11 @@ test.describe(
     });
 
     test.beforeEach('Visit entity details page', async ({ page }) => {
-      await user.login(page);
+      // Tour is entered from the welcome banner, so this suite must NOT suppress
+      // it. The other tour tests already guard against the banner if present.
+      await user.login(page, undefined, undefined, {
+        suppressWelcomeScreen: false,
+      });
     });
 
     test('Tour should work from help section', async ({ page }) => {

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/ExplorePageRightPanel_KnowledgeCenter.spec.ts

@@ -11,6 +11,7 @@
  *  limitations under the License.
  */
 
+import { Page } from '@playwright/test';
 import { KnowledgeCenterClass } from '../../support/entity/KnowledgeCenterClass';
 import { expect, test as baseTest } from '../../support/fixtures/userPages';
 import { Glossary } from '../../support/glossary/Glossary';
@@ -68,6 +69,31 @@ export const test = baseTest.extend<{
   },
 });
 
+/**
+ * Assert the owner chip is in the summary panel, re-opening the entity if it is
+ * not. The panel renders owners from the Explore search document, which is
+ * refreshed asynchronously after the owner PATCH — a panel that rendered before
+ * that refresh will never show the chip, so waiting on it is waiting on the
+ * wrong thing. Re-navigating re-reads it.
+ */
+async function expectOwnerInPanel(
+  page: Page,
+  entityName: string,
+  ownerName: string
+) {
+  const ownerChip = page
+    .locator('[data-testid="entity-summary-panel-container"]')
+    .getByTestId(ownerName);
+
+  await expect(async () => {
+    if (!(await ownerChip.isVisible())) {
+      await navigateToKCEntity(page, entityName);
+    }
+
+    await expect(ownerChip).toBeVisible({ timeout: 10_000 });
+  }).toPass({ timeout: 60_000, intervals: [2_000, 5_000] });
+}
+
 test.describe('Knowledge Center Right Panel Test Suite', () => {
   test.beforeAll(async ({ browser }) => {
     test.slow(true);
@@ -163,7 +189,6 @@ test.describe('Knowledge Center Right Panel Test Suite', () => {
       test('Should update owners for knowledgeCenter', async ({
         adminPage,
         rightPanel,
-        overview,
       }) => {
         await navigateToKCEntity(
           adminPage,
@@ -174,7 +199,11 @@ test.describe('Knowledge Center Right Panel Test Suite', () => {
         rightPanel.setEntityConfigByType('knowledgeCenter');
 
         await addOwnerInKCPanel(adminPage, user1.getUserDisplayName());
-        await overview.shouldShowOwner(user1.getUserDisplayName());
+        await expectOwnerInPanel(
+          adminPage,
+          getEntityDisplayName(knowledgeCenter.responseData),
+          user1.getUserDisplayName()
+        );
       });
     });
 
@@ -277,7 +306,11 @@ test.describe('Knowledge Center Right Panel Test Suite', () => {
         rightPanel.setEntityConfigByType('knowledgeCenter');
 
         await addOwnerInKCPanel(adminPage, user1.getUserDisplayName());
-        await overview.shouldShowOwner(user1.getUserDisplayName());
+        await expectOwnerInPanel(
+          adminPage,
+          getEntityDisplayName(knowledgeCenter.responseData),
+          user1.getUserDisplayName()
+        );
 
         await overview.removeOwner([user1.getUserDisplayName()], 'Users');
         await waitForAllLoadersToDisappear(adminPage);

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Glossary.spec.ts

@@ -44,6 +44,7 @@
   redirectToHomePage,
   uuid,
   visitGlossaryPage,
+  waitForAntdPopupToSettle,
 } from '../../utils/common';
 import {
   addMultiOwner,
@@ -1391,7 +1392,7 @@
     browser,
   }) => {
     // Create page and set up mocked WebSocket BEFORE navigation
     const page = await browser.newPage();
     await setupMockedWebSocket(page);
 
     // Login on this page (WebSocket is fully mocked, no real server connection)
@@ -1480,7 +1481,7 @@
     test.slow(true);
 
     // Create page and set up mocked WebSocket BEFORE navigation
     const page = await browser.newPage();
     await setupMockedWebSocket(page);
 
     // Login on this page
@@ -2194,10 +2195,12 @@
           .filter({ hasText: 'EN' })
           .first();
         await languageDropdown.click();
+        await waitForAntdPopupToSettle(page);
 
         const germanOption = page.getByRole('menuitem', {
           name: 'Deutsch - DE',
         });
+        await expect(germanOption).toBeVisible();
         await germanOption.click();
 
         await waitForAllLoadersToDisappear(page);
@@ -2230,10 +2233,12 @@
           .filter({ hasText: 'DE' })
           .first();
         await languageDropdown.click();
+        await waitForAntdPopupToSettle(page);
 
         const englishOption = page.getByRole('menuitem', {
           name: 'English - EN',
         });
+        await expect(englishOption).toBeVisible();
         await englishOption.click();
       });
     } finally {

openmetadata-ui/src/main/resources/ui/playwright/support/entity/ingestion/ServiceBaseClass.ts

@@ -218,7 +218,19 @@ class ServiceBaseClass {
     await waitForIngestionWorkflowForm(page);
     await this.fillIngestionDetails(page);
 
-    await page.click('[data-testid="next-button"]');
+    // Creating the service triggers AutoPilot, whose success toast renders
+    // bottom-center — directly over the wizard footer — and auto-closes after 5s
+    // (showSuccessToast(..., 5000) in AddServicePage). A click landing inside
+    // that window is intercepted by the toast, and with no per-action timeout
+    // the retry loop runs to the end of the test instead.
+    //
+    // Bounding the click is what fixes it, not waiting the toast out: the toast
+    // is fired by the create call several steps earlier, so whether it is on
+    // screen when we get here depends on how fast those steps ran. Gating on it
+    // being gone is a no-op when it has not rendered yet and when it has already
+    // closed. A bounded click covers every ordering — Playwright retries the
+    // intercepted click for the whole timeout, which outlasts the toast.
+    await page.click('[data-testid="next-button"]', { timeout: 30_000 });
 
     // Go back and data should persist
     await page.click('[data-testid="previous-button"]');

openmetadata-ui/src/main/resources/ui/playwright/support/user/AdminClass.ts

@@ -22,8 +22,9 @@ export class AdminClass extends UserClass {
   async login(
     page: Page,
     userName = DEFAULT_ADMIN_USER.userName,
-    password = DEFAULT_ADMIN_USER.password
+    password = DEFAULT_ADMIN_USER.password,
+    options: { suppressWelcomeScreen?: boolean } = {}
   ) {
-    await super.login(page, userName, password);
+    await super.login(page, userName, password, options);
   }
 }

openmetadata-ui/src/main/resources/ui/playwright/support/user/UserClass.ts

@@ -21,6 +21,7 @@ import { okJson, withNotFoundRetry } from '../../utils/apiResponse';
 import {
   disableEtagConditionalReads,
   generateRandomUsername,
+  suppressWelcomeScreen,
   uuid,
 } from '../../utils/common';
 import { PolicyClass, PolicyRulesType } from '../access-control/PoliciesClass';
@@ -257,8 +258,22 @@ export class UserClass {
   async login(
     page: Page,
     userName = this.data.email,
-    password = this.data.password
+    password = this.data.password,
+    options: { suppressWelcomeScreen?: boolean } = {}
   ) {
+    const { suppressWelcomeScreen: shouldSuppressWelcomeScreen = true } =
+      options;
+
+    // Seed `loggedInUsers` before the first navigation so the landing-page
+    // welcome banner never renders for this session. Prefer the authoritative
+    // entity name from create(); fall back to the login email's local-part
+    // (the server-assigned username) for a pure login such as admin. Tests that
+    // exercise the welcome banner itself (e.g. Tour) opt out with
+    // `suppressWelcomeScreen: false`.
+    if (shouldSuppressWelcomeScreen) {
+      await suppressWelcomeScreen(page, this.responseData?.name ?? userName);
+    }
+
     await page.goto('/signin');
     try {
       await page.waitForURL('**/signin', { timeout: 5000 });

openmetadata-ui/src/main/resources/ui/playwright/utils/activityFeed.ts

@@ -11,7 +11,7 @@
  *  limitations under the License.
  */
 import { expect, Locator, Page } from '@playwright/test';
-import { descriptionBox, removeLandingBanner } from './common';
+import { descriptionBox } from './common';
 import { waitForAllLoadersToDisappear } from './entity';
 import { waitForPageLoaded } from './polling';
 import { TaskDetails } from './task';
@@ -149,7 +149,6 @@
     const fetchFeedResponse = page.waitForResponse(
       '/api/v1/feed?type=Conversation*'
     );
-    await removeLandingBanner(page);
     await fetchFeedResponse;
   }
 
@@ -258,7 +257,7 @@
 export const navigateToActivityFeedTab = async (page: Page) => {
   await page.getByTestId('activity_feed').click();
   await waitForPageLoaded(page);
   await page.waitForSelector('[data-testid="loader"]', { state: 'detached' });
 };
 
 /**