Skip to content

ci: run the Collate check for any openmetadata-spec change - #31883

Closed
pmbrull wants to merge 1 commit into
mainfrom
pmbrull/ci-collate-check-openmetadata-spec
Closed

ci: run the Collate check for any openmetadata-spec change#31883
pmbrull wants to merge 1 commit into
mainfrom
pmbrull/ci-collate-check-openmetadata-spec

Conversation

@pmbrull

@pmbrull pmbrull commented Aug 21, 2026

Copy link
Copy Markdown
Member

Refs open-metadata/ai-platform#670. Companion to open-metadata/openmetadata-collate#6018.

Why

The workflow this dispatches (OpenMetadata Collate Test) now builds and tests the Collate AI Platform (CAIP) alongside the Collate server, so an OSS change that needs a matching CAIP change fails here instead of in a nightly image build.

CAIP's only OpenMetadata dependency is org.open-metadata:openmetadata-spec (agent/pom.xml, service/pom.xml). That module is more than JSON schemas — 321 of its tracked files are not under src/main/resources/json/schema/:

  • openmetadata-spec/pom.xml
  • hand-written interfaces: EntityInterface, CreateEntity, ServiceEntityInterface, …
  • ANTLR grammars: EntityLink.g4, Fqn.g4, JdbcUri.g4

Any of those can break the CAIP build, and none of them matched the schema-only path filter — so the check never fired.

Change

  • openmetadata-spec/src/main/resources/json/schema/**openmetadata-spec/**, on both push and pull_request_target.
  • Renamed the dispatch step and updated the branch comment to say the dispatched workflow covers CAIP too.

Workflow name: and job id are untouched, so no check name moves.

🤖 Generated with Claude Code

Greptile Summary

The PR renames the Collate dispatch step to mention AI Platform and documents that the selected Collate branch also determines the CAIP line. The current diff does not modify workflow triggers, path filters, permissions, or dispatch behavior.

Confidence Score: 5/5

The changed lines appear safe to merge.

No blocking failure remains in the changed workflow name or comments.

Important Files Changed

Filename Overview
.github/workflows/maven-build-collate.yml Changes only a step display name and explanatory comments; runtime workflow behavior remains unchanged.

Reviews (2): Last reviewed commit: "ci: note that the Collate check also cov..." | Re-trigger Greptile

Copilot AI lite review requested due to automatic review settings August 21, 2026 10:52
@pmbrull
pmbrull requested review from a team, akash-jain-10, harshach and tutte as code owners August 21, 2026 10:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Aug 21, 2026
Copilot AI review requested due to automatic review settings August 21, 2026 11:00
@pmbrull
pmbrull force-pushed the pmbrull/ci-collate-check-openmetadata-spec branch from 7760d93 to d58f94c Compare August 21, 2026 11:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

The dispatched `OpenMetadata Collate Test` workflow now builds and tests
the Collate AI Platform alongside the Collate server, so a change here
that needs a matching AI Platform change fails in this check rather than
in a nightly image build. Name the step and the branch comment for what
it now does.

Refs open-metadata/ai-platform#670

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings August 21, 2026 11:02
@pmbrull
pmbrull force-pushed the pmbrull/ci-collate-check-openmetadata-spec branch from d58f94c to 38af4de Compare August 21, 2026 11:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@pmbrull pmbrull closed this Aug 21, 2026
@gitar-bot

gitar-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Broadens CI workflow path filters to trigger Collate compatibility checks on any openmetadata-spec change rather than schema files alone. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants