Fix to source_generator to allow compatibility with OpenMC 0.15, and minor changes to CMakeLists.txt for dependencies. - #36
Open
rworrall-ukaea wants to merge 1 commit into
Conversation
…s to CMakeLists.txt including order of finding HDF5 package and find/include PythonLibs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenMC v0.15 changes CustomSourceWrapper to CompiledSourceWrapper which takes a pugixml node with an attribute for each of the parameter strings path_source_library and source_parameters, rather than the previous of passing both seperately as strings.
Minor addition to order of parametric_plasma_source/CMakeLists.txt to place the find_package for HDF5 higher up. Also the addition of find_package and include_directories for PythonLIbs.