fix(ui): default measurement value-type by measurement type (#604)

[skearnes]

Closes #604.

Problem

The Product Measurements value field always preselected the % value-type for every measurement type — so e.g. a Selectivity measurement defaulted to %, which is wrong for a ratio.

Cause

MeasurementValueControl used a single global defaultValueType = Percent with no per-type branching.

Fix

Pick the default value-type from the measurement's own type (MeasurementValueControl.tsx):

• Yield / Purity → %
• Amount → Mass
• everything else (Selectivity, Area, Counts, Intensity, Custom, …) → Number

Only applies when no value has been entered yet; saved measurements keep their stored type.

Tests

Parametrized tests assert the preselected value-type per measurement type (Selectivity→Number, Yield/Purity→%, Amount→Mass, Area→Number); existing numeric-render/view-only tests retained (mock updated for the new getValues read). tsc -b + lint green.

🤖 Generated with Claude Code

Greptile Summary

This PR fixes the Product Measurements UI always pre-selecting % as the value-type regardless of measurement kind. A per-type lookup map (YIELD/PURITY → Percent, AMOUNT → Mass, everything else → Number) now drives the default, applied only when no value has yet been stored.

• Adds measurementTypeToDefaultValueType and buildDefaultMeasurementValue, reading the sibling type field via formMethods.getValues(), replacing the former hard-coded Percent default.
• Test helper updated with a getValues stub and a parametrized it.each block asserting the correct pre-selection for Selectivity, Yield, Purity, Amount, and Area; field name corrected from "measurement" to "value" to match the actual form model.

Confidence Score: 5/5

Safe to merge — the change is narrowly scoped to the unset-value path, existing saved measurements are unaffected, and the new lookup map covers all types listed in valueCompatibleTypes.

The fix is small, well-bounded, and fully exercised by the updated parametrized tests. The getValues() call reads live form state (the parent re-renders on every dropdown change in Mantine's useForm, so the snapshot is always fresh on remount). No regressions introduced to saved data or view-only mode.

No files require special attention.

Important Files Changed

Filename	Overview
ui/src/features/reactions/ReactionEntities/entityFormConfiguration/measurements/MeasurementValueControl/MeasurementValueControl.tsx	Replaces single Percent default with a per-measurement-type lookup; adds buildDefaultMeasurementValue using getValues()?.type — logic is sound, types are safe, and only applies when no value has been entered.
ui/src/features/reactions/ReactionEntities/entityFormConfiguration/measurements/MeasurementValueControl/MeasurementValueControl.test.tsx	Adds makeFormMethods factory with getValues stub, corrects name from "measurement" to "value", and adds parametrized per-measurement-type default assertions. Coverage is good.

_{Reviews (1): Last reviewed commit: "fix(ui): default measurement value-type ..." | Re-trigger Greptile}

[pulumi]

🤖 Pulumi Neo didn't review this pull request: no Pulumi preview ran for it. Agentic reviews require a preview of the affected stacks (for example from your CI's pulumi preview).

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud