fix(ui): show measured value in per-record measurement summaries (#603) - #816
Open
skearnes wants to merge 1 commit into
Open
fix(ui): show measured value in per-record measurement summaries (#603)#816skearnes wants to merge 1 commit into
skearnes wants to merge 1 commit into
Conversation
Each measurement record's summary line under Conditions only showed Type (or Time), so multiple records looked identical. Add the measured value: Temperature and Pressure records now show their value, and Electrochemistry records show Voltage and Current alongside Time. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
🤖 Pulumi Neo didn't review this pull request: no Pulumi preview ran for it. Agentic reviews require a preview of the affected stacks (for example from your CI's |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #603.
Each measurement record's summary line under Conditions only showed Type (temperature/pressure) or Time (electrochemistry), so records with multiple entries were indistinguishable at a glance. This adds the measured value to each summary in reactionConditions.model.tsx:
All records already rendered; this only enriches each per-record summary.
tsc -b+ lint + entity-form unit tests green.🤖 Generated with Claude Code
Greptile Summary
Enriches the per-record summary lines shown under Conditions by appending the actual measured value alongside the existing Type/Time label, making multiple measurement records distinguishable at a glance.
Temperaturevalue next toType.Pressurevalue next toType.VoltageandCurrentalongside the existingTime.Confidence Score: 5/5
Safe to merge — the change is additive-only, touches a single file, and all new fields follow the existing rendering pattern already established by the Time field.
Three small, parallel additions that mirror the pre-existing
item.time ? renderValuePrecisionUnit(item.time) : ''pattern exactly. All referenced types match whatrenderValuePrecisionUnitaccepts. No logic is removed or restructured.No files require special attention.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(ui): show measured value in per-reco..." | Re-trigger Greptile