Skip to content

Stop injecting GitHub OAuth credentials into ord-interface #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skearnes merged 1 commit into from
Aug 5, 2026
Merged

Stop injecting GitHub OAuth credentials into ord-interface #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions stacks/interface/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,6 @@
backend = pulumi.StackReference("ord/backend/prod")
domain = pulumi.StackReference("ord/domain/prod")

github_client_secret = aws.secretsmanager.Secret(
"github_client_secret", name="github-client"
)
gh_arn = github_client_secret.arn
gh_client_id = gh_arn.apply(lambda arn: f"{arn}:GH_CLIENT_ID::") # ty: ignore[missing-argument, invalid-argument-type]
gh_client_secret = gh_arn.apply(lambda arn: f"{arn}:GH_CLIENT_SECRET::") # ty: ignore[missing-argument, invalid-argument-type]

# Anthropic API key for the natural-language search endpoint, named per-service so other
# services can have their own keys. The value is an encrypted Pulumi config secret.
config = pulumi.Config()
Expand All @@ -53,7 +46,6 @@
dockerfile="../../../ord-interface/ord_interface/Dockerfile",
secret_arns=[
backend.get_output("rds_password_secret_arn"),
github_client_secret.arn,
anthropic_api_key_secret.arn,
],
environment=[
Expand All @@ -76,14 +68,6 @@
name="POSTGRES_PASSWORD",
value_from=backend.get_output("rds_password_secret_arn"),
),
awsx.ecs.TaskDefinitionSecretArgs(
name="GH_CLIENT_ID",
value_from=gh_client_id,
),
awsx.ecs.TaskDefinitionSecretArgs(
name="GH_CLIENT_SECRET",
value_from=gh_client_secret,
),
awsx.ecs.TaskDefinitionSecretArgs(
name="ANTHROPIC_API_KEY",
value_from=anthropic_api_key_secret.arn,
Expand Down
Loading