Skip to content

Move off ord-schema's deprecated read_spreadsheet and name_resolve - #213

Merged
skearnes merged 1 commit into
mainfrom
drop-deprecated-ord-schema-api
Jul 28, 2026
Merged

Move off ord-schema's deprecated read_spreadsheet and name_resolve#213
skearnes merged 1 commit into
mainfrom
drop-deprecated-ord-schema-api

Conversation

@skearnes

@skearnes skearnes commented Jul 28, 2026

Copy link
Copy Markdown
Member

templating.read_spreadsheet and resolvers.name_resolve are forwarding aliases left behind by ord-schema's load_*/save_* rename, and ord-schema#909 removes them. The editor server is the only place in this repository that used either.

Both replacements have identical signatures to the aliases they replace and are already present in the pinned ord-schema 0.8 — load_spreadsheet(file_name_or_buffer, suffix=None) and resolve_name(value_type, value) — so each call site is a rename and nothing else.

The pin stays at ord-schema[orm]>=0.8,<0.9. That bound is what insulates this repository from #909 today; widening it is a separate change once 0.9.0 ships, and this makes the code ready for it.

Verification

ruff check, ruff format --check, and ty check pass, and I confirmed against the installed 0.8 that both new names resolve with the expected signatures. Both call sites do have test coverage — test_enumerate_dataset and test_resolve_compound in serve_test.py — but those live under ord_interface/editor, which the first CI job excludes and the second runs behind PostgreSQL, Redis, and puppeteer; they need the CI services rather than a local run, so I am relying on this PR's own run for them.

🤖 Generated with Claude Code

Greptile Summary

Updates the editor server to use the supported ord-schema API names.

  • Replaces templating.read_spreadsheet with templating.load_spreadsheet.
  • Replaces resolvers.name_resolve with resolvers.resolve_name.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The replacement APIs preserve the existing arguments and return contracts and are available throughout the declared ord-schema dependency range.

Important Files Changed

Filename Overview
ord_interface/editor/py/serve.py Both deprecated aliases are replaced with equivalent APIs available in the repository’s supported ord-schema version range.

Reviews (1): Last reviewed commit: "Move off ord-schema's deprecated read_sp..." | Re-trigger Greptile

Both are forwarding aliases left by the load_*/save_* rename, and
open-reaction-database/ord-schema#909 removes them. The replacements --
templating.load_spreadsheet and resolvers.resolve_name -- have identical
signatures and are present in the pinned ord-schema 0.8, so both call sites are
a rename.

The pin stays at >=0.8,<0.9; widening it waits for 0.9.0 to ship.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@skearnes
skearnes merged commit 93efaa4 into main Jul 28, 2026
16 checks passed
@skearnes
skearnes deleted the drop-deprecated-ord-schema-api branch July 28, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant