Move off ord-schema's deprecated read_spreadsheet and name_resolve - #213
Merged
Conversation
Both are forwarding aliases left by the load_*/save_* rename, and open-reaction-database/ord-schema#909 removes them. The replacements -- templating.load_spreadsheet and resolvers.resolve_name -- have identical signatures and are present in the pinned ord-schema 0.8, so both call sites are a rename. The pin stays at >=0.8,<0.9; widening it waits for 0.9.0 to ship. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
templating.read_spreadsheetandresolvers.name_resolveare forwarding aliases left behind by ord-schema'sload_*/save_*rename, and ord-schema#909 removes them. The editor server is the only place in this repository that used either.Both replacements have identical signatures to the aliases they replace and are already present in the pinned ord-schema 0.8 —
load_spreadsheet(file_name_or_buffer, suffix=None)andresolve_name(value_type, value)— so each call site is a rename and nothing else.The pin stays at
ord-schema[orm]>=0.8,<0.9. That bound is what insulates this repository from #909 today; widening it is a separate change once 0.9.0 ships, and this makes the code ready for it.Verification
ruff check,ruff format --check, andty checkpass, and I confirmed against the installed 0.8 that both new names resolve with the expected signatures. Both call sites do have test coverage —test_enumerate_datasetandtest_resolve_compoundinserve_test.py— but those live underord_interface/editor, which the first CI job excludes and the second runs behind PostgreSQL, Redis, and puppeteer; they need the CI services rather than a local run, so I am relying on this PR's own run for them.🤖 Generated with Claude Code
Greptile Summary
Updates the editor server to use the supported ord-schema API names.
templating.read_spreadsheetwithtemplating.load_spreadsheet.resolvers.name_resolvewithresolvers.resolve_name.Confidence Score: 5/5
The PR appears safe to merge with no actionable defects identified.
The replacement APIs preserve the existing arguments and return contracts and are available throughout the declared ord-schema dependency range.
Important Files Changed
Reviews (1): Last reviewed commit: "Move off ord-schema's deprecated read_sp..." | Re-trigger Greptile