Import natural-language translation from ord_schema.agent

[skearnes]

Blocked on ord-schema#919 landing and shipping a release. ty and CI cannot resolve ord_schema.agent until then, so checks here will be red for a reason that has nothing to do with this diff. Review the two together.

The translation half of nl_query moved to ord_schema.agent, next to the schema it describes. What remains here is serving, and separating them makes that boundary explicit rather than implied.

nl_query.py goes from 484 lines to 270.

What this side supplies

RedisCache adapts Redis to the Cache protocol ord-schema declares. The protocol requires best-effort semantics — a miss on failure, dropped writes, never an exception — which the existing _redis_get/_redis_set helpers already guaranteed, so the adapter is a rename rather than new behaviour.

_as_http_error maps NLQueryError subclasses onto the status codes the endpoint already returned: 429 rate limited, 503 unavailable, 502 malformed. ord-schema raises plain exceptions now; nothing about this API's contract changes.

build_query_params stays, because mapping a resolved interpretation onto QueryParams is this backend's concern, not the schema's.

Tests

The tests that covered translation and structure resolution moved with the code they test. What remains here covers the QueryParams mapping, the translation cache, and the endpoint — the things this repo actually owns. Patch targets moved accordingly: resolve_name and canonicalize_smiles are now patched on ord_schema.agent.nl_query, which is a useful signal in itself that the seam is in the right place.

79 API tests pass against ord-schema#919 installed from its branch, plus ruff check and ruff format --check.

The eval harness stays

nl_query_eval.py also exercises run_query, which needs a database, so it stays here and reads the prompt and eval cases from ord_schema.agent. Splitting it into a translation-accuracy half and an end-to-end half is worth doing, but it is not this PR.

Frontend

Untouched. app/src/types/search.ts comments still say "Mirrors ord_interface.api.nl_query.NLQuery" — those types are re-exported from this module, so the comments remain accurate, though they could be pointed at the new home in a follow-up.

🤖 Generated with Claude Code

Greptile Summary

The PR moves natural-language translation responsibilities into ord-schema while retaining the serving integration here.

• Imports translation models, resolution, cache-key generation, and model handling from ord_schema.agent.
• Adds a Redis adapter and maps library translation exceptions to existing HTTP responses.
• Moves evaluation fixtures and translation-focused tests out of this repository.
• Declares the ord-schema agent extra in project and lockfile dependency metadata.

Confidence Score: 4/5

The PR is not safe to merge until the locked ord-schema release provides the newly imported agent module.

The current lockfile still installs ord-schema 0.8.0, whose resolved metadata does not provide the agent extra, while application startup unconditionally imports ord_schema.agent.nl_query and therefore fails before routes can be served.

Files Needing Attention: pyproject.toml, uv.lock, ord_interface/api/nl_query.py

Important Files Changed

Filename	Overview
ord_interface/api/nl_query.py	Replaces local translation and resolution implementations with ord_schema.agent imports while retaining endpoint, caching, error mapping, and QueryParams construction.
ord_interface/api/nl_query_eval.py	Imports shared evaluation cases and interpretation checks from ord-schema while retaining database-backed evaluation.
ord_interface/api/nl_query_test.py	Refocuses tests on serving-layer query mapping, translation caching, endpoint behavior, and exception mapping.
pyproject.toml	Adds the agent extra to the ord-schema dependency declaration and removes package-data entries for migrated fixtures.
uv.lock	Updates the root package requirement metadata to request both agent and orm ord-schema extras.

_{Reviews (2): Last reviewed commit: "Cover the status-code mapping the move i..." | Re-trigger Greptile}

[skearnes]

Closing alongside ord-schema#919, which this was the companion to.

That PR moved the translation layer into ord-schema so we could iterate on it against the projection; on review, most of it encodes the current ORM backend's predicate list rather than anything reusable for a 389-column query surface, so the replacement is being written fresh instead.

The consequence for this repo is that nothing needs to change yet. ord_interface/api/nl_query.py keeps working as it stands, against the search backend it was written for. When projection-backed search is ready, this module gets deleted in one move rather than refactored twice — which also avoids the interim coupling this PR carried, where it could not go green until ord-schema shipped a release containing the new package.

🤖 Generated with Claude Code