fix: stop double-passing engine kwarg in _bind_engine patch - #19
Open
robotlearning123 wants to merge 1 commit into
Open
robotlearning123 wants to merge 1 commit into
robotlearning123 wants to merge 1 commit into
Conversation
The generate() wrapper injected engine=... while also forwarding the caller's kwargs; pipeline.py already passes engine=self.engine, so every h3 run died with TypeError: got multiple values for keyword argument 'engine'. Drop any caller-supplied engine kwarg before injecting — the bound (CLI-configured) engine is authoritative. Fixes #17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_bind_enginewrappedbackend.generatewith a lambda that injectedengine=...while also forwarding the caller's**kw;core/pipeline.py:90already callsgenerate(req, engine=self.engine), so every h3 run raisedTypeError: generate() got multiple values for keyword argument 'engine'.enginekwarg before injecting the bound one — the CLI-configured engine (--server) is authoritative, matching the binding's documented intent.tests/test_bind_engine.py: drives the realH3Backend.generatethrough the patched path with a recording engine double; asserts noTypeErrorand that the bound engine object (identity) is the one that ran.Test plan
pytest tests/test_bind_engine.py— red on main (TypeErrorreproduced), green on this branchpytest tests/— 61 passedFixes #17