Skip to content

fix: preserve custom env vars in multi-user mode via sudo -E #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Blumlaut wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve custom env vars in multi-user mode via sudo -E #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion open_terminal/utils/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ def __init__(self, command: str, cwd: str | None, env: dict | None, run_as_user:
if run_as_user:
# Build the inner command: optionally cd first, then run the command.
inner = f"cd {shlex.quote(cwd)} && {command}" if cwd else command
command = f"sudo -u {shlex.quote(run_as_user)} -- bash -c {shlex.quote(inner)}"
# ``sudo`` resets the environment by default. ``-E`` preserves
# it so that caller-supplied env vars (e.g. ``GH_TOKEN``) actually
# reach the child process.
command = f"sudo -E -u {shlex.quote(run_as_user)} -- bash -c {shlex.quote(inner)}"
cwd = None # Popen runs as parent user — can't chdir into chmod 700 dirs
master_fd, slave_fd = pty.openpty()
try:
Expand Down