fix: support Windows filesystem paths - #156
Open
mikemikimike wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #154.
/files/serve/{path}instead of prepending/toC:/...paths.os.access(path, os.W_OK)wheneffective_ids=Trueis unsupported on Windows.Compatibility
This preserves the existing leading-slash behavior for POSIX and relative paths. On Windows, drive-letter paths are passed through unchanged. No API changes are introduced.
Verification
pytest -q tests/test_windows_compatibility.py— 2 passed (one existing pytest deprecation warning)python -m compileall -q open_terminal— passedgit diff --check— passedThe full test suite was not run because the repository currently has no existing test suite beyond the focused regression coverage added here. Docker image builds were not run because this change is limited to Python unit behavior and does not alter image configuration.