Skip to content

[harness] Decisions impact required in every repository #71

Open

Description

@BotshareAI

Owner: CI owner (@wikki26).

Goal: every PR in every enrolled repository answers Decisions impact (None, Consumer with entry IDs, or Change with a change request), and the evidence check enforces it.

Introduced by #70.

Per repository:

  1. Add the "Decisions impact" section to the repository's own PR template, as in openAMRobot/.github .github/PULL_REQUEST_TEMPLATE.md.
  2. Add --decisions, --files-json and --repository to its PR assistant's evidence step (rollout/workflows/pr-assistant.yml).
  3. After two weeks of warnings, add --require-decisions-impact.
  • .github
  • openamr-platform-sw
  • openamr-platform-fw
  • openamr-platform-hw
  • openamr-upperbody-sw
  • openamr-upperbody-fw
  • openamr-upperbody-hw
  • openamrobot-interfaces
  • openamrobot-manipulation
  • openamrobot-ui
  • openamrobot-comm
  • openamrobot-docs
  • openamrobot-manifest
  • openamrobot-release
  • openamrobot-embodied-ai

Done when every box is ticked and a PR without the section fails the evidence check in each repository.

Activity

  1. wikki26 commented on Oct 31, 2026

    @wikki26

    CI owner triage, 31 October 2026:

    This is a staged organization rollout, not a one-PR cross-repository bulk edit. The prerequisite harness design is still open in .github #70; safety/publishing review must close there before assuming that its planned automation or --require-decisions-impact behavior is active.

    Suggested order after the owner accepts the evidence-check contract:

    1. First verify the canonical example on .github and pin the applicable checker revision, with a deliberately missing or malformed Decisions impact fixture.
    2. Roll out the template and --decisions --files-json --repository checker arguments to software repos in small reviewed batches, using warning-only reporting as documented.
    3. Track actual false positives/negatives and repository owners' reviews for two weeks; only then enforce --require-decisions-impact where the prerequisite checker/run evidence is green.
    4. Treat firmware, hardware, CODEOWNERS and workflow edits as protected paths needing the corresponding human approvals. Record each repository's measured check result and reviewer instead of marking it complete from a copied template.

    Current work priorities: security review patch .github #76 awaiting Alex/Mohammad, platform shared gate #101 with DCO identity correction/re-review, and main-published image .github #41. The interfaces shared gate #29 is already merged with passing main checks; that does not by itself implement this additional PR-description policy.

    No repository is marked complete in #71 until the explicit Decisions impact acceptance check is demonstrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions