Replace pybids with ancpBIDS#94
Open
apdavison wants to merge 2 commits into
Open
Conversation
Replaces pybids and bids-validator with ancpbids as the BIDS layout engine. A layout_to_df() shim in converter.py bridges the ancpBIDS native API to the pandas DataFrame expected by the rest of the pipeline, so main.py and utility.py are unchanged. ancpBIDS correctly treats CTF MEG .ds directories as single artifacts rather than enumerating their internal files (BadChannels, ClassFile.cls, etc.), which is the correct BIDS interpretation. The ds000247 expected file count in the test suite is updated accordingly (202 → 120).
* main: Update codemeta.json for 0.2.0 release Release 0.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following on from the discussion in #69, this PR replaces pybids with ancpBIDS as the BIDS layout engine. This is a prerequisite for using ancpBIDS's metadata inheritance engine (
get_metadata()) to generate in-depth neuroimaging metadata in a future PR.A
layout_to_df()shim inconverter.pybridges the ancpBIDS native API to the pandasDataFrameexpected by the rest of the pipeline, somain.pyandutility.pyare unchanged. In future, we could drop the DataFrame interface, if it seems like a good idea.Of the two motivations for replacing pybids mentioned in #69, this PR deals with "a lot of additional dependencies we don't need", and lays the groundwork for "does not extract all the things we need".
Dependency changes
pybids (main): 33 packages
ancpBIDS (this branch): 18 packages
Packages dropped entirely: