Skip to content

adding some more mathematical shapes#187

Merged
Raphael-Gazzotti merged 77 commits into
v5from
lzehl_mathShapes
Mar 3, 2026
Merged

adding some more mathematical shapes#187
Raphael-Gazzotti merged 77 commits into
v5from
lzehl_mathShapes

Conversation

@lzehl
Copy link
Copy Markdown
Member

@lzehl lzehl commented Aug 9, 2022

related to #186

@lzehl
Copy link
Copy Markdown
Member Author

lzehl commented Aug 9, 2022

@xgui3783 and @apdavison before I continue here I would need your feedback.
Goal of these schemas are to define mathematical shapes without defining an actual coordinate space.

Which one do we most likely need ? How do we define them best / consistently ?

@xgui3783
Copy link
Copy Markdown
Collaborator

xgui3783 commented Aug 9, 2022

My immediate focus is that (IMO) all are 2D shapes, except sphere, which IMO is a 3D concept. Its 2D concept would be a circle.

I can Imagine circle used.

Would line segment also be included (or is it already included in a previous commit?)

Seems strange to not have rectangle, though one would argue that a rectangle is a special parallelogram. But the same can be said for square.

@lzehl
Copy link
Copy Markdown
Member Author

lzehl commented Aug 9, 2022

@xgui3783 #186 has various 3D shapes besides sphere. But before I implement them I wanted to have feedback.

I would define a line as a coordinate point only within a given space. Therefore it is excluded here from mathematical shapes that are defined without a space. There will be another PR in connection with the annotation revision with a Contour schema (which can be a line).

Note that circle, rectangle and ellipse were already added to mathematical shapes in a previous PR.

@UlrikeS91 UlrikeS91 added the request any request or update for schemas label May 8, 2024
@apdavison apdavison changed the base branch from v3 to v5 November 7, 2025 17:09
@lzehl lzehl marked this pull request as ready for review February 24, 2026 14:17
@lzehl lzehl self-assigned this Feb 24, 2026
@lzehl
Copy link
Copy Markdown
Member Author

lzehl commented Feb 24, 2026

There can be more added (specifically for 3D) but I would like to clarify first if we want all of them for convenience or if we want to kick out all the ones that are theoretically covered by general classes.

Note: mathematical shapes should be space independent represented (since they are later to be placed an a coordinate framework). For this reason I avoided terms such as height, depth, etc (which also caused issues when defining 3D shapes as composites from 2D shapes).

Comment thread schemas/mathematicalShape/cube.schema.tpl.json Outdated
Comment thread schemas/mathematicalShape/ellipsoid.schema.tpl.json
Comment thread schemas/mathematicalShape/kite.schema.tpl.json
Comment thread schemas/mathematicalShape/regularPolygon.schema.tpl.json
Copy link
Copy Markdown
Member

@Raphael-Gazzotti Raphael-Gazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment:
I am not sure all the specialized prism, pyramid, frustum shapes are necessary. We could define a general Prism/Pyramid/Frustum with a baseShape property using _embeddedTypes (e.g., Rectangle, Triangle, etc.). This would provide the same flexibility while avoiding multiple specialized prism/pyramid/frustum schemas. That said, specialized variants may still be justified if certain techniques or devices depend on explicitly defined shapes.

For the arrays of QuantitativeValue, it’s unclear whether the values are expected to follow a specific order (e.g., major and minor diameters for an ellipse). if ordering matters, this should be clearly specified in the instructions.

@lzehl lzehl requested a review from Raphael-Gazzotti March 3, 2026 11:28
Comment thread schemas/mathematicalShape/centroidalPyramid.schema.tpl.json Outdated
@Raphael-Gazzotti Raphael-Gazzotti self-requested a review March 3, 2026 12:01
Co-authored-by: Raphael-Gazzotti <125291580+Raphael-Gazzotti@users.noreply.github.com>
@lzehl lzehl requested a review from Raphael-Gazzotti March 3, 2026 16:52
@Raphael-Gazzotti Raphael-Gazzotti merged commit 07443d8 into v5 Mar 3, 2026
2 checks passed
@Raphael-Gazzotti Raphael-Gazzotti deleted the lzehl_mathShapes branch March 3, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

request any request or update for schemas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adding further shapes (as first assessment, with further extension based on use cases)

4 participants