fix(test): capture raw test output and prevent leak of debug messages - #89
Merged
Merged
Conversation
okurz
force-pushed
the
feature/stabilize_and_improve_tests
branch
2 times, most recently
from
August 3, 2026 06:48
322e2d8 to
52f660b
Compare
okurz
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Motivation: Raw STDOUT/STDERR from set_pipes => 0 processes and compile-time debug mode warnings polluted the test runner TAP output. Design Choices: Use Test::Output's combined_from and stderr_like to capture extraneous print statements, and safely reload the module with DEBUG disabled after testing. Benefits: The prove output is now a completely clean list of passing test files.
okurz
force-pushed
the
feature/stabilize_and_improve_tests
branch
from
August 3, 2026 07:21
52f660b to
e3bca8d
Compare
Martchus
approved these changes
Aug 3, 2026
okurz
force-pushed
the
feature/stabilize_and_improve_tests
branch
from
August 3, 2026 15:30
e0b8f0b to
16031d8
Compare
Motivation: Process objects registered with Session created a strong reference cycle. This leaked process objects and their pipe file descriptors. Design Choices: Weaken the registered process reference inside Session. Also update clean() and all_processes() to safely handle undefined references. Benefits: Fixes memory and file descriptor leaks, ensuring processes and their pipes are closed immediately when going out of scope. Related issue: openSUSE#86
okurz
force-pushed
the
feature/stabilize_and_improve_tests
branch
from
August 3, 2026 15:39
16031d8 to
986177a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.