Fix for the issue of Deleting multiple sensors at once.#850
Open
JerryVincent wants to merge 1 commit intodevfrom
Open
Fix for the issue of Deleting multiple sensors at once.#850JerryVincent wants to merge 1 commit intodevfrom
JerryVincent wants to merge 1 commit intodevfrom
Conversation
Coverage Report
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Implementation
The bug was in the post-save cleanup loop in the device/$deviceId/edit/sensors route - when iterating forward and calling splice, removing an element shifts the array left, causing the next element to land on the same index that the loop then skips over. The fix changes the loop to iterate backwards (from the last element to the first), so any splice only affects elements that have already been processed, guaranteeing no sensor is skipped. The duplicate new && notValidInput branch was also removed since it was redundant.
Checklist
devbranchAdditional Information