Communicate issues with the mail delivery with user.#856
Open
JerryVincent wants to merge 3 commits intodevfrom
Open
Communicate issues with the mail delivery with user.#856JerryVincent wants to merge 3 commits intodevfrom
JerryVincent wants to merge 3 commits intodevfrom
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Implementation
When email delivery fails during user-facing flows (registration, password reset request, email address change), users are now notified with a clear, actionable message instead of failing silently or showing a generic server error. In registerUser, the sendMail call is wrapped in a try-catch that returns an emailSent: false flag on failure; the registration route then renders a dedicated card confirming the account was created while explaining the confirmation email could not be sent, and directs the user to log in and resend from account settings. For the forgot-password flow, the existing try-catch now maps to a proper i18n key so the error message is fully translated. For email address changes in account settings, the resendEmailConfirmation call is similarly guarded, and a destructive toast is shown if delivery fails — leaving the resend button accessible for an immediate retry. All error messages prompt the user to try again later or open a bug report if the issue persists, and the corresponding translation keys were added for both English and German.
Checklist
devbranchAdditional Information