Skip to content

Communicate issues with the mail delivery with user.#856

Open
JerryVincent wants to merge 3 commits intodevfrom
feat/CommunicateMailIssues
Open

Communicate issues with the mail delivery with user.#856
JerryVincent wants to merge 3 commits intodevfrom
feat/CommunicateMailIssues

Conversation

@JerryVincent
Copy link
Collaborator

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

When email delivery fails during user-facing flows (registration, password reset request, email address change), users are now notified with a clear, actionable message instead of failing silently or showing a generic server error. In registerUser, the sendMail call is wrapped in a try-catch that returns an emailSent: false flag on failure; the registration route then renders a dedicated card confirming the account was created while explaining the confirmation email could not be sent, and directs the user to log in and resend from account settings. For the forgot-password flow, the existing try-catch now maps to a proper i18n key so the error message is fully translated. For email address changes in account settings, the resendEmailConfirmation call is similarly guarded, and a destructive toast is shown if delivery fails — leaving the resend button accessible for an immediate retry. All error messages prompt the user to try again later or open a bug report if the issue persists, and the corresponding translation keys were added for both English and German.

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

@github-actions
Copy link

github-actions bot commented Mar 25, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 69.5% 1716 / 2469
🔵 Statements 67.77% 1788 / 2638
🔵 Functions 69.35% 353 / 509
🔵 Branches 56.63% 935 / 1651
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/lib/user-service.server.ts 77.32% 68.85% 70.58% 81.01% 100-104, 142-146, 161-165, 192-193, 309-311, 420-468, 482, 535-563, 576, 621, 622
Generated in workflow #2300 for commit dde6439 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Communicate issues with mail delivery to the user

1 participant