Skip to content

Rebrand: ghpool → octobroker#47

Merged
chaodu-agent merged 3 commits into
mainfrom
rebrand-octobroker
Jul 22, 2026
Merged

Rebrand: ghpool → octobroker#47
chaodu-agent merged 3 commits into
mainfrom
rebrand-octobroker

Conversation

@chaodu-agent

Copy link
Copy Markdown
Contributor

Summary

ghpool outgrew its name. What started as a PAT pooler is now a credential broker: agents get MCP tools, REST/GraphQL reads, and git push with zero GitHub credentials in the container. New name: octobroker (octopus = one body, many arms — one endpoint, many orgs/agents/protocols; broker = what it actually does). Domain secured: octobroker.dev.

Changes (mechanical rename, no behavior changes)

Before After
crate/binary ghpool octobroker
CLI crate/binary ghp obk
GHPOOL_* env vars OCTOBROKER_*
X-Ghpool-Key header X-Octobroker-Key
~/.config/ghpool/ ~/.config/octobroker/
GHPOOL_CONFIG OCTOBROKER_CONFIG
release artifacts ghpool-* octobroker-*
  • README opener rewritten to current positioning (MCP + REST + git push, zero-credential claim, multi-org)
  • ghp_xxx PAT literal examples intentionally untouched
  • Docs, workflows, Dockerfile, e2e script all updated; zero residual references (git grep -i ghpool clean)

Breaking changes (deliberate, no compat shims — pre-1.0)

  • Deployments must rename env vars, config dir, and the agent key header
  • Agent containers: ghp binary → obk (git credential helper config line changes)
  • MCP client configs: X-Ghpool-KeyX-Octobroker-Key

Tested

  • cargo build --release + cargo test on macOS arm64: server 127 passed, obk CLI 5 passed, 0 failed

After merge

  • Rename GitHub repo openabdev/ghpoolopenabdev/octobroker (old URLs redirect)
  • Update GitHub repo description
  • Point octobroker.dev at the repo/docs
  • Update deployed instances' env/config/header names

- Crate ghpool → octobroker; CLI crate/binary ghp → obk (ghp/ → obk/)
- Env vars GHPOOL_* → OCTOBROKER_*; agent header X-Ghpool-Key → X-Octobroker-Key
- Config path ~/.config/ghpool → ~/.config/octobroker; OCTOBROKER_CONFIG
- Docker image, release artifact names, workflows, e2e script, docs updated
- New positioning in README opener + Cargo description; octobroker.dev linked
- PAT literal examples (ghp_xxx) intentionally unchanged
- Repo URLs point at openabdev/octobroker (rename repo on merge)
- Phase 1/2 future-tense notes → present tense (per-agent keys and
  repo allowlists shipped in 2a/2b)
- MCP client examples show X-Octobroker-Key as the recommended setup;
  network-trust mode noted as the fallback
- 'What it does' gains the git credential broker bullet
@chaodu-agent

Copy link
Copy Markdown
Contributor Author

Note

LGTM ✅ — clean mechanical rename with correct preservation of the things that must NOT be renamed; conflict with main resolved by rebase onto v0.6.0 (head 5798e34).

What This PR Does

Rebrands ghpool → octobroker: crate/binary names (ghpooloctobroker, ghpobk), env vars (GHPOOL_*OCTOBROKER_*), agent key header (X-Ghpool-KeyX-Octobroker-Key), config paths (~/.config/octobroker/, OCTOBROKER_CONFIG), release artifacts, docs, workflows, Dockerfile, and e2e script. Deliberately breaking, no compat shims (pre-1.0).

Findings

# Severity Finding Resolution
1 🟡 Branch was CONFLICTING with main — it predated the v0.6.0 release commit, carrying version = "0.5.1"; CI could not run on the merge ref ✅ Rebased onto main; conflict resolved to octobroker @ 0.6.0; PR is now MERGEABLE and CI passes on 5798e34
2 🟡 Cargo.lock package entry was stale at 0.3.4 — pre-existing drift (release-pr.yml only seds Cargo.toml, never the lock) surfaced by the rename ✅ Corrected to 0.6.0 in the rebase. Follow-up (non-blocking): make release-pr.yml update the lock too
3 🟡 PR body understates test coverage: "obk CLI 5 passed" — the crate has 20 unit + 5 integration tests, all passing ℹ️ Documentation inaccuracy only; counts verified below
4 🟢 The ghp_ GitHub PAT prefix literals (ghp_xxx examples in README/config) were correctly NOT renamed — the one string a naive rename would have broken
5 🟢 Rename completeness verified: git grep -i ghpool → zero residual references outside lock history; header rename fully consistent (61 x-octobroker-key refs, 0 x-ghpool in src/ + obk/); ci.yml paths updated ghp/**obk/**; Docker tags derive from github.repository so they follow the repo rename automatically

Verified (at rebased head 5798e34, arm64 macOS)

  • server: cargo clippy --all-targets -- -D warnings clean; cargo test127 passed, 0 failed; binary builds as octobroker
  • obk: clippy clean; 20 unit + 5 integration passed; binary builds as obk
  • GitHub CI: passing on the rebased head

5️⃣ Three Reasons We Might Not Need This PR

  1. Renames churn deployments — true, but the breaking changes are explicit, pre-1.0, and the deployed fleet is one ECS service + one agent container we control.
  2. "ghpool" still describes the PAT pool — the PAT pool is now the legacy read path; the product is the broker (MCP + REST + git credentials). The old name actively misleads.
  3. Do it later — every release under the old name grows the migration surface (artifact names, image tags, helper configs). v0.6.0 just shipped; the window before the deploy is the cheapest moment.

Reminder for the after-merge checklist: deployed instances need OCTOBROKER_* env/config/header renames before rolling the new image, and B0's future credential-helper config uses obk git-credential, not ghp.

@chaodu-agent
chaodu-agent merged commit dbb5b18 into main Jul 22, 2026
1 check passed
@chaodu-agent
chaodu-agent deleted the rebrand-octobroker branch July 22, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant