fix: keep rescue task calls in foreground#214
Draft
lttlin wants to merge 1 commit intoopenai:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
codex:codex-rescuecan orphan Codex runs in worktree isolation when the rescue agent backgrounds its singletaskBash call. Claude Code cleans up the temporary worktree as soon as the agent returns, leaving Codex running in a deleted directory.Root Cause
The rescue forwarding instructions still allow backgrounding the inner
codex-companion.mjs task ...Bash call, and the command-contract tests do not enforce that the inner task must always run in the foreground.Fix
Update the rescue agent and runtime skill to require foreground execution for the inner
taskBash call in all cases.--backgroundand--waitremain outer Claude-side controls, but they no longer authorizerun_in_background: trueon the inner task invocation.Validation
node --test --test-name-pattern='rescue command absorbs continue semantics|internal docs use task terminology' tests/commands.test.mjsnode --test tests/commands.test.mjsstill has an unrelated pre-existing failure in theresult and cancel commands are exposed as deterministic runtime entrypointsassertion onmainCloses #198