[codex] Reconcile stale running jobs when pid exits#225
Draft
LawrenceChiu95 wants to merge 1 commit intoopenai:mainfrom
Draft
[codex] Reconcile stale running jobs when pid exits#225LawrenceChiu95 wants to merge 1 commit intoopenai:mainfrom
LawrenceChiu95 wants to merge 1 commit intoopenai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runningjobs when the tracked pid no longer existsstate.json) and per-job file (jobs/<id>.json)failedRoot Cause
/codex:statustrusted persisted state forrunningjobs without validating whether the worker process was still alive. If a worker died unexpectedly, the job could remainrunningindefinitely and appear stuck.Changes
plugins/codex/scripts/lib/state.mjsprocess.kill(pid, 0))listJobs()for stalerunningjobs with dead pidsfailedwitherrorMessage,completedAt, andpid: nulltests/state.test.mjslistJobs auto-reconciles stale running jobs when pid is no longer aliveValidation
node --test tests/state.test.mjsnode --test tests/runtime.test.mjs --test-name-pattern "status shows phases|status preserves adversarial review kind labels|status --wait times out cleanly|cancel without a job id ignores active jobs from other Claude sessions|cancel with a job id can still target an active job from another Claude session|stop hook logs running tasks to stderr without blocking when the review gate is disabled"