feat(typescript): add findings service plumbing - #653
Open
kmbroai wants to merge 2 commits into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 tasks
kmbroai
commented
Aug 26, 2026
| docker run --rm codex-security:ci bulk-scan --help | ||
| docker run --rm codex-security:ci info --json | ||
|
|
||
| - name: Verify findings service and persistent SQLite storage |
Collaborator
Author
There was a problem hiding this comment.
simple test. this is extracted to a script in the next PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the first stage of a Docker-hosted findings service in the TypeScript SDK. The service initializes the existing SQLite workbench and exposes two explicitly mocked HTTP endpoints, without adding a CLI command.
Changes
src/server/.GET /v1/findingsandPOST /v1/bulk/findings. Each logs only its route and returns HTTP 501 with{"error":"not_implemented"}; request bodies are not processed or logged.start:serverscript and afindings-serviceDocker target. Docker invokes the same compiled SDK entrypoint directly so stop signals reach the server.Testing
Verified at
620586e4:12345and1566945902).pnpm run types,pnpm run format, changed workflow formatting, andgit diff --check: passed.Risk and rollout
pnpm run start:server; server-specific environment settings areHOST(local default127.0.0.1) andPORT(default3000). Existing state-directory and Python settings are reused.0.0.0.0:3000; Compose publishes only on the host loopback interface. The preview has no API authentication and should not be exposed to an untrusted network without an authenticated proxy.Public disclosure review