fix(windows): stabilize credential inspection and test subprocesses - #662
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Final validation for
The PR is ready for review and has not been merged. |
Summary
Fix the two Windows failures in the latest main CI run: interrupted credential ACL enumeration during concurrent ambient imports, and a Python test subprocess that returned no exit status.
Changes
Get-ChildItemfile-disappearance error and retry the complete credential ACL snapshot through the existing three-attempt loop. Finish validating streamed descriptors before starting another attempt.execFile, retaining its timeout and output assertions. This small fixture change also appears in the broader CI work in ci: balance test shards and stabilize CI checks #651.Testing
dbfd8dca6a: 32 checks passed and 5 release-only checks skipped. This includes all Linux, macOS, and Windows runtime lanes, package checks, both previously failing Windows shards, and the machine-wide PowerShell policy check.638943413and12345: each passed 27 tests with 5 Windows-only skips and 0 failures.pnpm run types: passed.pnpm run format: passed.pnpm run build: passed.git diff --check: passed.pnpm run test --seed 12345under restricted process access: 1,891 passed, 30 skipped, and 6 failed. Five long-running fixture/subprocess timeouts passed focused reruns; the sixth was an explicitly sandbox-deniedpscall.pnpm run testwith normal process access, seed3628695636: 1,897 passed, 29 skipped, and 1 failed. The existing CLI-export asynchronous-write test exceeded its three-second deadline; an immediate isolated replay and five further isolated repetitions passed. That unrelated test is unchanged. These local full-suite attempts are not claimed green.Risk and rollout
The production change is limited to the Windows credential ACL inspection path. Only the observed file-disappearance error requests a fresh snapshot; permission and other inspection failures still reject the operation. No public CLI, dependency, timeout, retry-limit, or CI-matrix changes. Unix behavior is unchanged. This PR does not merge or release the fix.
Public disclosure review