fix(publish): retain recovery guidance on canceled uploads - #680
fix(publish): retain recovery guidance on canceled uploads#680mldangelo-oai wants to merge 5 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e28127ab7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b04e0425e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex security review Please review current head f57a29a. The original fix in #677 is now merged, so this PR changes only CLI recovery presentation and tests. Request tracking now begins at the POST boundary and resets between batch entries. All 118 focused tests, typechecking, formatting, build, and real-signal CLI smoke tests pass. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Keep the caller's cancellation reason without losing Cloud upload recovery guidance. An interrupted upload may already have been accepted, so the CLI must still tell users to check Cloud before retrying.
Follow-up to merged #677. Its caller-cancellation change stays unchanged; this PR preserves the matching CLI recovery behavior.
Changes
SIGINTorSIGTERM.Testing
cloud-publish.test.ts,cli-cloud-publish.test.ts, andcli-publish.test.ts.SIGINTandSIGTERMboth retained recovery guidance, exited with 130/143, and made only one request.pnpm run types,pnpm run format, andpnpm run build: passed.git diff --check: passed.Risk and rollout
The production change is limited to cancellation propagation and error presentation. It adds no public flags, configuration, dependencies, or retry behavior. Cancellation still exits with 130 for
SIGINTand 143 forSIGTERM; confirmed receipts and unattempted batch entries are preserved. Picker, dry-run, and Linear cancellation behavior remain unchanged. The recovery message is conditional and does not claim that an upload was accepted.Public disclosure review