feat(cli): enable cancellable scans over MCP - #682
Open
kmbroai wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
Security findingsAdvisory findings (1)ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Security Review
Here are some automated security review suggestions for this pull request.
Reviewed commit: b109ea3440
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCP clients can currently inspect CLI metadata but cannot run security scans. This change exposes a
scantool throughcodex-security --mcp, so another agent can run scans and receive structured results without invoking a shell command for each scan.Changes
{ exitCode, data?, error? }outcome, preserving findings when coverage is incomplete or a severity policy fails. Keep concurrent requests independent.Testing
12345: 1,937 passed, 29 platform skips, 0 failed in each run. Tests ran withumask 077so temporary outputs satisfy the existing permission checks.git diff --check: passed.Risk and rollout
This adds the
scantool to the existing stdio--mcpinterface; existing CLI flags and defaults remain unchanged. MCP scan arguments use camelCase option names and excludepatch,patchSeverity, andcreatePr.info.scanMcpnow reportstrue.The server runs locally with its configured credentials and filesystem access. Scans may incur model costs, write artifacts, and run repository tools. Clients must allow enough time for scans and use cancellation to stop unwanted work. No network listener or separate service is introduced. The direct MCP SDK dependency uses the version already present through Incur.
Public disclosure review