test(windows): make canonical plugin path fixtures portable - #684
test(windows): make canonical plugin path fixtures portable#684faizan-oai wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review the current head This changes only two existing Python fixtures: path comparison and synthetic home selection. All three Windows failures reproduced on unmodified main; all 70 tests in the affected files pass natively after the correction. Production behavior, workflows, and test skips are unchanged. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Fix three reproducible failures in the shared Python contract tests when run natively on Windows. These are test-fixture portability defects, not demonstrated failures of the installed CLI.
Changes
Path, so Git's forward slashes and native Windows separators identify the same fixture. Keep bothcp932andcp949decoding cases.USERPROFILEalongsideHOMEin the legacy tilde-scope fixture, matching Python's Windows home expansion.Testing
9bd256a; the two relevant scripts and both tests were checked against that commit's Git blobs.3.12.13/ pytest9.0.3:python -m pytest plugins/codex-security/tests/test_workbench_target.py plugins/codex-security/tests/test_generate_rank_input.py -v— 70 passed, 0 failed, 0 skipped, 78.43 seconds. JUnit output confirms the same totals.git diff --check: passed. No Python formatter is configured for these files; the existing style is preserved.Risk and rollout
Test-only change with no runtime or public CLI changes. Unicode decoding and legacy tilde behavior remain asserted on both platforms. No extra dependencies, arbitrary limits, or platform exclusions are introduced.
Public disclosure review