Skip to content

test(plugin): accept a detached MCP payload - #688

Open
soyeon-oai wants to merge 2 commits into
mainfrom
codex/detached-mcp-test-payload
Open

test(plugin): accept a detached MCP payload#688
soyeon-oai wants to merge 2 commits into
mainfrom
codex/detached-mcp-test-payload

Conversation

@soyeon-oai

@soyeon-oai soyeon-oai commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

Allow MCP runtime and smoke tests to validate a detached, materialized plugin payload instead of requiring the SDK-local generated payload path.

Changes

  • accept CODEX_SECURITY_TEST_PLUGIN_ROOT as the complete plugin payload used for shipped-runtime and end-to-end smoke assertions
  • preserve the existing SDK _bundled_plugin path as the default

Testing

  • confirmed the test fails when the generated SDK payload is absent before this change
  • built a complete plugin into a temporary directory with buildBundledPlugin
  • ran the complete test:mcp suite with CODEX_SECURITY_TEST_PLUGIN_ROOT set to that temporary plugin

Risk and rollout

Low risk. Production plugin behavior is unchanged. Existing SDK test callers retain the same default; alternate plugin materializers can opt into the override.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the skip-release-notes Omit internal changes from generated release notes label Aug 27, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-27T21:37:06.662137Z a6d8a7a PR opened
🔒 Security Review Completed 2026-08-27T21:37:15.540080Z a6d8a7a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Omit internal changes from generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant