Skip to content

test(windows): retry busy comparison fixture cleanup #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faizan-oai wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −3
Open

test(windows): retry busy comparison fixture cleanup #702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions sdk/typescript/tests-ts/scan-comparison.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
} from "node:fs/promises";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { setTimeout as delay } from "node:timers/promises";
import {
Codex,
type CodexOptions,
Expand All @@ -29,11 +30,27 @@ import {

const temporaryDirectories: string[] = [];

async function removeTemporaryDirectory(path: string): Promise<void> {
// Bun 1.3.14 does not implement fs.rm's recursive retry options.
for (let attempt = 0; ; attempt += 1) {
try {
await rm(path, { recursive: true, force: true });
return;
} catch (error) {
if (
process.platform !== "win32" ||
(error as NodeJS.ErrnoException).code !== "EBUSY" ||
attempt >= 10
)
throw error;
await delay(100 * (attempt + 1));
}
}
}

afterEach(async () => {
await Promise.all(
temporaryDirectories
.splice(0)
.map((path) => rm(path, { recursive: true, force: true })),
temporaryDirectories.splice(0).map(removeTemporaryDirectory),
);
});

Expand Down
Loading