Skip to content

fix(plugin): remove conflicting reporting rule - #705

Merged
ianw-oai merged 2 commits into
mainfrom
dev/ianw/clarify-internal-path-policy
Aug 28, 2026
Merged

fix(plugin): remove conflicting reporting rule#705
ianw-oai merged 2 commits into
mainfrom
dev/ianw/clarify-internal-path-policy

Conversation

@ianw-oai

@ianw-oai ianw-oai commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Remove the rule to ignore internal-only paths. It contradicts the next paragraph, which says internal exposure alone is not a reason to ignore a finding.

Changes

Delete one bullet and format the Markdown. Keep the attacker-path requirements and privileged-access exclusions.

Testing

  • 121 focused tests passed.
  • Prettier check passed.
  • git diff --check passed.

Risk and rollout

Policy text only. No CLI or API changes.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Aug 28, 2026
@ianw-oai
ianw-oai requested review from kmbroai and soyeon-oai and a lite review from Copilot August 28, 2026 05:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the attack-path analysis severity policy reference to remove a reportability suppression rule that conflicted with adjacent guidance about internal exposure not being sufficient reason to ignore a finding.

Changes:

  • Removed the “internal-only / developer-only / operator-only / localhost-only … set ignore” bullet from the reportability decision section.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ianw-oai
ianw-oai marked this pull request as ready for review August 28, 2026 05:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review Completed 2026-08-28T05:59:30.776419Z 3109173 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ianw-oai
ianw-oai merged commit 2331860 into main Aug 28, 2026
25 checks passed
@ianw-oai
ianw-oai deleted the dev/ianw/clarify-internal-path-policy branch August 28, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants