fix: prevent stack trace exposure in flask-playwright API responses#1669
Open
rajkumar-prog wants to merge 2 commits into
Open
fix: prevent stack trace exposure in flask-playwright API responses#1669rajkumar-prog wants to merge 2 commits into
rajkumar-prog wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #1543
The Flask app in
evals/elsuite/multistep_web_tasks/docker/flask-playwright/app.pyexposes raw exception details directly in API responses at 4 locations:/setup—f"failed to start session (already started?): {e}"leaks exception message/exec_command—"content": str(e)leaks TypeError details/exec_commands—"content": str(e)leaks TypeError details_execute_command()—f"error executing command {command}: {e}"leaks exception + command contentStack traces and internal error details should never be sent to clients — they expose internal system information that can aid attackers.
Fix
At all 4 locations:
logger.error()so it's still captured for debuggingChanges
evals/elsuite/multistep_web_tasks/docker/flask-playwright/app.py— 4 locations patched