Fix EVALS_SHOW_EVAL_PROGRESS env var parsing#1670
Open
LeSingh1 wants to merge 1 commit into
Open
Conversation
bool("0") evaluates to True in Python, so setting
EVALS_SHOW_EVAL_PROGRESS=0 or =false did not disable the progress bar
as users would expect. Replace bool(os.environ.get(...)) with an
explicit string check matching the convention used for EVALS_SEQUENTIAL
and EVALS_GENTLE_INTERRUPT in the same file. When the variable is unset,
the caller-supplied show_progress argument is preserved.
LeSingh1
requested review from
andrew-openai,
etr2460 and
katyhshi
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bool(os.environ.get(...))treats the string"0"as truthy, so settingEVALS_SHOW_EVAL_PROGRESS=0(or=false) on the command line did not disable the tqdm progress bar as expected.Replace the
bool(...)call with an explicit string check, matching the pattern already used forEVALS_SEQUENTIALandEVALS_GENTLE_INTERRUPTin the same file. When the env var is unset, the caller-suppliedshow_progressargument is preserved.Before:
After:
Added unit tests covering the unset, truthy, and falsy cases.