Skip to content

Export cached formula values instead of formula #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonwoerpel merged 2 commits into from
Apr 7, 2026
Merged

Export cached formula values instead of formula #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ef6768
add data_only flag
jlstro Mar 18, 2026
3261fe6
🚨 Make black happy
simonwoerpel Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions ingestors/tabular/xlsx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
import logging
from xml.etree.ElementTree import ParseError

from followthemoney import model
from openpyxl import load_workbook
from xml.etree.ElementTree import ParseError

from ingestors.exc import ProcessingException
from ingestors.ingestor import Ingestor
from ingestors.support.table import TableSupport
from ingestors.support.ooxml import OOXMLSupport
from ingestors.exc import ProcessingException
from ingestors.support.table import TableSupport

log = logging.getLogger(__name__)


class ExcelXMLIngestor(Ingestor, TableSupport, OOXMLSupport):
MIME_TYPES = [
"application/vnd.openxmlformats-officedocument.spreadsheetml.sheet", # noqa
"application/vnd.openxmlformats-officedocument.spreadsheetml.template", # noqa
"application/vnd.openxmlformats-officedocument.spreadsheetml.sheet", # noqa: B950
"application/vnd.openxmlformats-officedocument.spreadsheetml.template", # noqa: B950
"application/vnd.ms-excel.sheet.macroenabled.12",
"application/vnd.ms-excel.sheet.binary.macroenabled.12",
"application/vnd.ms-excel.template.macroenabled.12",
Expand All @@ -35,7 +35,9 @@ def ingest(self, file_path, entity):
entity.schema = model.get("Workbook")
self.ooxml_extract_metadata(file_path, entity)
try:
book = load_workbook(file_path, read_only=True)
# "controls whether cells with formulae have either the formula
# (default) or the value stored the last time Excel read the sheet"
book = load_workbook(file_path, read_only=True, data_only=True)
except Exception as err:
raise ProcessingException("Invalid Excel file: %s" % err) from err

Expand Down
Loading