Skip to content

Add kloudfuse#176

Open
ashishkf wants to merge 2 commits intoopenapm:masterfrom
ashishkf:patch-1
Open

Add kloudfuse#176
ashishkf wants to merge 2 commits intoopenapm:masterfrom
ashishkf:patch-1

Conversation

@ashishkf
Copy link

No description provided.

@ashishkf
Copy link
Author

ashishkf commented Apr 5, 2023

Can I please get review on this?

Copy link
Contributor

@arile01 arile01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, I left some comments for request changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide the file as a png as well as in a square format? Not using a square format would result in the logo not being displayed correctly but cropped instead

- datadog-agent
- fluentbit
- opentelemetry
- prometheus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to reference another id from within the components here. In that sense 'prometheus' does not exist as an id and the data model cannot be build correctly.
You can check the prometheus.yml file to see which id's are available and use whichever component is suitable e.g. 'prometheus-exposition-format' or 'prometheus-exporter'

name: kloudfuse
description: Kloudfuse is a unified monitoring and observability platform covering metrics, traces and logs, events, etc. Kloudfuse supports all open source agents and data collection sources (prometheus, open telemetry, fluentbit, etc.) and also promql, logql and traceql.
link: https://www.kloudfuse.com/
github: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there is no GitHub reference just remove the field altogether, just as within the definition for other commercial tools. E.g. AppDynamics also has no GitHub link in the component definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants