Skip to content

Fix zone location creation in case there is no tile child. #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DivineThreepwood merged 2 commits into from
Mar 4, 2025
Merged

Fix zone location creation in case there is no tile child. #148

DivineThreepwood merged 2 commits into from
Mar 4, 2025

Conversation

@DivineThreepwood
Copy link
Member

@DivineThreepwood DivineThreepwood commented Feb 23, 2025

📜 Description

Changes proposed in this pull request:

  • Implement test that reproduces the location zone issue.
  • Fix consistency handling by defining tile as default location type.

✅ Checklist:

  • Created tests which fail without the change (if possible)
  • Extended the documentation (if necessary)

@DivineThreepwood
Implement test that reproduces the location zone issue. Fix consisten…
f05bcbc 
…cy handling by defining tile as default location type.
@DivineThreepwood DivineThreepwood linked an issue Feb 23, 2025 that may be closed by this pull request
A zone is saved as a tile. #147
Closed
@netlify
Copy link

netlify bot commented Feb 23, 2025 •
edited
Loading

✅ Deploy Preview for basecubeone canceled.

Name Link
🔨 Latest commit 7da6fa9
🔍 Latest deploy log https://app.netlify.com/sites/basecubeone/deploys/67bb9f8315ecb00008510419

@DivineThreepwood DivineThreepwood changed the title Implement test that reproduces the location zone issue. Fix consisten… Fix zone location creation in case there is no tile child. Feb 23, 2025
@DivineThreepwood DivineThreepwood self-assigned this Feb 23, 2025
@DivineThreepwood DivineThreepwood merged commit 7efff16 into dev Mar 4, 2025
8 checks passed
@DivineThreepwood DivineThreepwood deleted the bugfix/#147_fix_zone_auto_detection branch March 4, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhuxohl lhuxohl lhuxohl approved these changes

@pLeminoq pLeminoq Awaiting requested review from pLeminoq

@LukBelter LukBelter Awaiting requested review from LukBelter

Assignees

@DivineThreepwood DivineThreepwood

Labels

code approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A zone is saved as a tile.

3 participants

@DivineThreepwood @lhuxohl