fix: remove explicit transformers library from model export commands - #173
Open
manuelinfosec wants to merge 1 commit into
Open
fix: remove explicit transformers library from model export commands#173manuelinfosec wants to merge 1 commit into
manuelinfosec wants to merge 1 commit into
Conversation
Collaborator
Author
|
I made these changes myself, but this PR reverts them as they don't work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the explicit
--library-name transformersargument from the model export commands indata/download-model.tsanddata/prepare-embeddings.ts.The export tooling no longer needs the library to be specified explicitly, so this simplifies the model export configuration while preserving the existing model and INT8 export flow.
Type of change
Areas affected
Checklist
bun run typecheckpassescargo clippypasses without warningsbun run testpasses (if applicable)Tested on
Screenshots / recordings
No UI changes.