Skip to content

feat(recovery): report the instance id of a skipped record (0.11.3) - #19

Merged
GeneralPawz merged 2 commits into
mainfrom
fix/skipped-record-instance
Nov 3, 2026
Merged

GeneralPawz merged 2 commits into
mainfrom
fix/skipped-record-instance

Conversation

@GeneralPawz

Copy link
Copy Markdown
Contributor

Closes #17.

A SkippedRecord diagnostic now reports the record's id through Diagnostic::instance() when its #id token was read, as written (leading zeros kept, like DuplicateId). A record skipped before its #id was read still gives None. The sequential, parallel and event parses share the recovery loop, so all three agree; decode_record_with never skips.

The instance() doc covers the limits:

  • one skip that swallows several records names only the first (follow-up issue to come);
  • the id is the token that was read, not proof that no kept record uses it;
  • compare it with a dangling id after removing leading zeros.

Released as 0.11.3. The change is additive and has no known consumer of the old None.

Gate: ./scripts/gate.sh passes.

…was read

openbimrs/ifc needs the id to name a dropped record and to keep it from
being reused. The id is reported as written, like a duplicate's; a skip
over several records names only the first.

Closes #17
@GeneralPawz
GeneralPawz merged commit 1ecfcc3 into main Nov 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report the instance id of a skipped record whose #id was read

1 participant