Repository navigation
feat(recovery): report the instance id of a skipped record (0.11.3) - #19
Merged
Merged
Conversation
…was read openbimrs/ifc needs the id to name a dropped record and to keep it from being reused. The id is reported as written, like a duplicate's; a skip over several records names only the first. Closes #17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17.
A
SkippedRecorddiagnostic now reports the record's id throughDiagnostic::instance()when its#idtoken was read, as written (leading zeros kept, likeDuplicateId). A record skipped before its#idwas read still givesNone. The sequential, parallel and event parses share the recovery loop, so all three agree;decode_record_withnever skips.The
instance()doc covers the limits:Released as 0.11.3. The change is additive and has no known consumer of the old
None.Gate:
./scripts/gate.shpasses.