Skip to content

Add neutral page retry handling#531

Merged
AlbertoCasasOrtiz merged 4 commits into
opencap-org:devfrom
csherry04:neutral-retry
Jul 24, 2026
Merged

Add neutral page retry handling#531
AlbertoCasasOrtiz merged 4 commits into
opencap-org:devfrom
csherry04:neutral-retry

Conversation

@csherry04

@csherry04 csherry04 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Applied the existing retry helper throughout the neutral page. Addressed #500 by resetting the busy state upon error. For the record request did less retries on shorter timing to prevent users waiting too long with no feedback

added an extra guard to make sure actions can't be triggered a second time while retry is happening
@csherry04

csherry04 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

This pr has now been expanded to apply to the session page in addition to neutral and includes a new locking mechanism for start/stop to integrate the block that I put in for the retry logic with the logic from #493

in effect made it so there is a minimum locking time as per the times used in the #493 but it will also be blocked when retry is in flight. This means if there are no retries and it completes quickly, the button will be blocked for the remaining time diff of time used in #493 - time for action to be completed

figured this unifies logic in a sensible way, let me know what you think @AlbertoCasasOrtiz

@AlbertoCasasOrtiz

Copy link
Copy Markdown
Member

@csherry04 There are conflicts with dev in this PR. Let me know when those are solved and I will review.

@csherry04

Copy link
Copy Markdown
Contributor Author

@AlbertoCasasOrtiz should be resolved

@AlbertoCasasOrtiz

Copy link
Copy Markdown
Member

Tested the solution to #500 and to #493 and seems to work properly. I will test a full session recording under different conditions to assess that the retry works properly. From the code, it seems it will work.

@AlbertoCasasOrtiz
AlbertoCasasOrtiz merged commit ec65c8e into opencap-org:dev Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants