Confirm neutral pose before processing#534
Conversation
Allow extra recording cameras and improve scene resizing
Merge pull request opencap-org#526 from opencap-org/local_saving
|
@keevindoherty thanks for submitting this PR! Agreed that waiting on a neutral trial that you expect to fail is not great for the user. We have some high-throughput data collections where our users are trying to minimize any extra time to collect data, so one suggestion would be to add this feature as an Advanced Option, where the options could be something like: Neutral video upload confirmation
@AlbertoCasasOrtiz could also help out with suggestions, reviewing, testing, etc. if helpful too |
|
Also an FYI, I switched the target branch for this PR and the accompanying PR in |
|
Thank you for this feature @keevindoherty! This is looking good, definitely something our users need. I will review this soon and add commit here to convert it into an |
Summary
This PR along with a companion on opencap-api opencap-org/opencap-api#302 adds a dialog box for the user to confirm a good neutral pose capture before processing.
Often it can happen that you're trying to record a neutral pose, but for one reason or another the recording goes poorly and you know it won't be useful for processing (e.g. the person you're recording moves, you accidentally start recording). Since neutral pose recordings are automatically processed, the user might have to wait several minutes to start again. Instead, this PR allows a user to just abort right away.
cc: @ashcollimore
Testing
I didn't go through mocking the full backend locally, so I couldn't test this very rigorously. If you have suggestions for me to test locally that you'd prefer me to implement before merging, let me know. The diff is pretty small though, so it might be easier to grab my changes and quickly run against a dev database if you have one set up?
Here's that dialog box in the viewer locally on my machine: