Repository navigation
Design cleanup - #12
Merged
Merged
Conversation
…andling - Introduced a new script for capturing Open Graph images of components. - Updated `component-image.ts` to utilize the new screenshot functionality when available. - Enhanced `component-seo.ts` to include logic for generating image versions based on component metadata and screenshots. - Modified `library/registry.tsx` to support new card structure with aspect ratios and Open Graph settings. - Adjusted `Components.tsx` to handle Open Graph capture requests and improved grid layout for component display. - Added tests to verify new functionality and ensure proper rendering of components without placeholders.
…into design-cleanup
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/componentsrun and respond in place: draw track, hover the folder, scroll the deck. Each tile's name row ("Name · Open →") opens the component page.shared/component-meta.tsgains an optionalcreditUrl./components/<slug>?og=1renders one component on a 1200×630 frame.corepack pnpm og:components(scripts/capture-component-og.ts) photographs each frame with the local Chrome intopublic/og/components/<slug>.png, and records a hash per picture inshared/component-og.ts./api/component-imageserves the picture when one exists, otherwise the text card. The share-link version includes the hash, so previews refresh when a picture changes.How I checked it
corepack pnpm typecheck: passes.corepack pnpm lint: 0 errors (the warnings are the existing fast-refresh ones).corepack pnpm test: 757 passed, 62 skipped.Anything left to check
Pictures not captured yet: run
corepack pnpm og:componentsbefore merging and commitpublic/og/components/withshared/component-og.ts; until then every component uses the text card.Not checked in a browser: the new tile shapes and the live previews (drawing, hovering, scrolling) on desktop, tablet and phone.
Scroll Deck tile: it takes wheel scrolling while the pointer is over it, and hands back to the page at its ends. Decide whether that's right for the grid.
Production file path: on Pxxl, check that one share-image URL returns the picture after deploying. The endpoint reads
dist/og/componentsorpublic/og/componentsfrom the server's working folder.I kept this pull request focused and updated the relevant documentation.
I added regression coverage for a bug fix where useful.
I kept secrets, private member details and generated files out of the changes.