Repository navigation
Design cleanup - #14
Merged
Merged
Conversation
- Improved the cleanup process for the temporary Chrome profile by adding a wait for Chrome to finish shutting down before removal. - Added error handling for profile deletion to ensure safe cleanup. - Updated the script documentation to reflect the correct file extension used in the generation process.
…into design-cleanup
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
corepack pnpm og:componentscaptured every screenshot but then exited with an error (ENOTEMPTY) while deleting Chrome's temporary profile, because Chrome was still writing to it as it shut down.The script now waits up to 5 seconds for Chrome to exit, deletes the profile with retries, and only warns if the folder still can't be removed. Also corrects the script name in the header comment of
shared/component-og.ts.How I checked it
corepack pnpm typecheck: passes.tests/component-og-image.test.tsandtests/component-seo.test.ts: 12 passed.Opened all four captured images in
public/og/components/: Draw a Line, Scroll Deck, Split Footer and Icon Folder all render correctly at 1200×630.I kept this pull request focused and updated the relevant documentation.
I added regression coverage for a bug fix where useful.
I kept secrets, private member details and generated files out of the changes.