Skip to content

Design cleanup - #14

Merged
Psybah merged 2 commits into
mainfrom
design-cleanup
Nov 19, 2026
Merged

Psybah merged 2 commits into
mainfrom
design-cleanup

Conversation

@Psybah

@Psybah Psybah commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

What changed

corepack pnpm og:components captured every screenshot but then exited with an error (ENOTEMPTY) while deleting Chrome's temporary profile, because Chrome was still writing to it as it shut down.

The script now waits up to 5 seconds for Chrome to exit, deletes the profile with retries, and only warns if the folder still can't be removed. Also corrects the script name in the header comment of shared/component-og.ts.

How I checked it

  • corepack pnpm typecheck: passes.

  • tests/component-og-image.test.ts and tests/component-seo.test.ts: 12 passed.

  • Opened all four captured images in public/og/components/: Draw a Line, Scroll Deck, Split Footer and Icon Folder all render correctly at 1200×630.

  • I kept this pull request focused and updated the relevant documentation.

  • I added regression coverage for a bug fix where useful.

  • I kept secrets, private member details and generated files out of the changes.

- Improved the cleanup process for the temporary Chrome profile by adding a wait for Chrome to finish shutting down before removal.
- Added error handling for profile deletion to ensure safe cleanup.
- Updated the script documentation to reflect the correct file extension used in the generation process.
Copilot AI balanced review requested due to automatic review settings November 19, 2026 01:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@Psybah
Psybah merged commit 46dda82 into main Nov 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants