fix: clarify observation and runtime refusal diagnostics - #727
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
PR SummaryLow Risk Overview Bridge observation errors now say the provider returned inconsistent response evidence and name the mismatch directly (e.g. CLI human status lines for Docs and changelog add an unreleased note and a Reviewed by Cursor Bugbot for commit 972f9b7. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Codex review: needs maintainer review before merge. Reviewed September 12, 2026, 9:45 PM ET / September 13, 2026, 01:45 UTC (Revision 2). ClawSweeper reviewWhat this changesClarifies Bridge observation error messages and CLI runtime-refusal guidance, with two regression tests, troubleshooting documentation, and a changelog entry. Merge readiness✅ Ready for maintainer review The diagnostics fix remains useful: current main and v4.3.4 retain the misleading wording. No actionable correctness or security findings remain, and the related merged fixes address separate behavior. Priority: P3 Review scores
Verification
How this fits togetherPeekaboo’s Bridge validates desktop observations returned by a runtime host. Rejected evidence becomes an error that the CLI presents with recovery guidance. flowchart TD
A[Desktop observation request] --> B[Runtime host capture]
B --> C[Bridge evidence validation]
C --> D[Accepted observation]
C --> E[Refusal and evidence detail]
E --> F[CLI diagnostic and recovery guidance]
Before mergeNone. Agent review detailsSecurityNone. Review metricsNone. Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Technical reviewBest possible solution: Keep structured refusal semantics stable while describing inconsistent evidence accurately and directing users to inspect the selected runtime. Do we have a high-confidence way to reproduce the issue? Yes, from source: current main interpolates diagnostic phrases into a target-oriented sentence and maps runtime incompatibility to unconditional update advice; no native reproduction was executed during this review. Is this the best way to solve the issue? Yes. Changing the two presentation strings and documenting existing verbose diagnostics is a narrow repair that preserves machine-readable behavior. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 6916848ab2fa. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
Observation binding failures used one sentence template for both target fields and diagnostic phrases, producing errors such as “did not match the requested unexpected application evidence.” The message now identifies the inconsistent evidence directly. Generic runtime-refusal guidance asks callers to verify the selected runtime, since an evidence bug can occur with matching current builds; structured refusal codes, escalation values, and specific update hints remain unchanged. The troubleshooting guide explains how
--verboseidentifies the selected host/socket.Addresses the diagnostic portion of #710; capture attribution and file publication are handled by #722 and #725.
Before:
After:
Validation: the new observation-message regression failed against the old implementation. All 8 Bridge result tests and 39 CLI error-output tests pass; lint, format, and docs checks pass. Isolated Codex review found no actionable P0–P2 findings. A signed external native executable built against the real Bridge validator refused two synthetic responses and emitted the expected messages for both
unexpected application evidenceandrequested application identity. No desktop capture or model call was required.