chore(deps): refresh Swift validation and Node qualification runtime - #731
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
PR SummaryMedium Risk Overview Re-pins the macOS qualification Node app from 24.15.0 to 26.8.2 end-to-end: download URLs, archive/binary/license/universal SHA256 and size, zip artifact names, manifest schema checks, fixture tests, and docs that describe terminal qualification. CFBundleVersion is now computed from the semver (e.g. Tightens macOS CI by running Hardens agent/skill guidance: expanded press-route checks for Refactors the element-detection “timeout wins over noncooperative work” regression to use a synchronization gate instead of wall-clock timing, asserting the timeout returns without releasing blocked work. Reviewed by Cursor Bugbot for commit c3d2eac. Bugbot is set up for automated code reviews on this repo. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8024b84. Configure here.
clawsweeper
Bot
added
P3
|
Codex review: blocked before merge. Reviewed September 13, 2026, 1:55 PM ET / 17:55 UTC (Revision 7). ClawSweeper reviewWhat this changesUpdates Swift and Node validation runtimes, refreshes the pinned macOS Node bundle, adds a CLI catalog smoke check, and strengthens guidance and timeout tests. Merge readiness⛔ Blocked before merge - 2 items remain Keep open: the runtime refresh remains distinct from current main and the latest release. The reviewed patch has no blocking code findings, and the earlier bundle-version concern is resolved. Priority: P3 Review scores
Verification
How this fits togetherPeekaboo’s build tooling combines official Node binaries into a universal macOS runtime used for terminal qualification. Artifact validators check its identity and integrity before the packaging pipeline publishes a candidate. flowchart TD
A[Official Node archives] --> B[Checksum verification]
B --> C[Universal runtime bundle]
C --> D[Signing and notarization]
D --> E[Artifact manifest validation]
E --> F[Qualified package candidate]
Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep the synchronized runtime pins and integrity checks, with production package acceptance established before landing the refresh. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a runtime and validation refresh, and source review found no introduced blocking defect. No target builds or tests were executed during this read-only review. Is this the best way to solve the issue? Yes: updating the existing builder, validators, fixtures, and CI together preserves one qualification contract without introducing a parallel runtime path. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against a744b91e70b8. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (6 earlier review cycles)
|
clawsweeper
Bot
added
the
proof: sufficient
1 participant
Update Node to stable 26.8.2 in CI and the pinned macOS qualification runtime, and Linux Commander validation to Swift 6.3.3. Both clear the repository’s 48-hour release-age window. The archive, architecture-binary, license, universal-binary, and size pins move together across the producer and validators. CFBundleVersion is derived from the Node pin (260802), with generated-plist regression checks.
The macOS CLI job launches its freshly built executable and validates its JSON tool catalog. Declared Node/Swift/macOS consumer floors are preserved; the official Node binaries declare macOS 13.5, below Peekaboo’s macOS 15 requirement. The guidance and timeout-test prerequisite landed separately in #732, and main’s #730 window implementation/tests are preserved.
Validation for
c3d2eac0dad7b7626963cac680b0fc6551b06425:Held: audited chrome-devtools-mcp 1.6.0 (newer versions violate background user-activation policy); pnpm 12 lockfile compatibility and the too-young 11.27.0; KeyboardShortcuts 3.1.0 inside 48 hours; Ubuntu 26.04 lacks an official Swift 6.3.3 toolchain; five submodule pointer updates are held because the required autoreview helper rejects gitlink changes. The full sweep report records exact versions and reasons.