Skip to content

fix: clarify unsupported session control errors#123

Merged
vincentkoc merged 5 commits intoopenclaw:mainfrom
manthan787:codex/issue-11-actionable-set-errors
Mar 12, 2026
Merged

fix: clarify unsupported session control errors#123
vincentkoc merged 5 commits intoopenclaw:mainfrom
manthan787:codex/issue-11-actionable-set-errors

Conversation

@manthan787
Copy link
Contributor

Summary

  • wrap session/set_mode and session/set_config_option failures with actionable guidance when adapters reject params
  • detect both direct JSON-RPC invalid params (-32601/-32602) and wrapped adapter errors (-32603 with data.details containing Invalid params)
  • include command context (requested mode/config/value) in the surfaced error message
  • extend the mock ACP agent with flags to simulate codex-style invalid-params behavior for session control methods
  • add CLI coverage asserting improved error output for set-mode and set

Why

Issue #11 calls out that codex adapters may reject session/set_config_option / session/set_mode, and current output can be opaque. This change keeps the same runtime behavior but makes the failure path explicit and actionable for users.

Test Plan

  • corepack pnpm run format:check
  • corepack pnpm run typecheck
  • corepack pnpm exec oxlint --type-aware src
  • corepack pnpm run lint:persisted-key-casing
  • corepack pnpm run build
  • corepack pnpm run build:test
  • node --test dist-test/test/cli.test.js
  • node --test dist-test/test/client.test.js

References #11.

Manthan and others added 5 commits March 12, 2026 00:37
)

Bumps the development group with 4 updates: [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node), [lint-staged](https://github.com/lint-staged/lint-staged), [oxfmt](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxfmt) and [oxlint](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxlint).


Updates `@types/node` from 25.3.5 to 25.4.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `lint-staged` from 16.3.2 to 16.3.3
- [Release notes](https://github.com/lint-staged/lint-staged/releases)
- [Changelog](https://github.com/lint-staged/lint-staged/blob/main/CHANGELOG.md)
- [Commits](lint-staged/lint-staged@v16.3.2...v16.3.3)

Updates `oxfmt` from 0.36.0 to 0.37.0
- [Release notes](https://github.com/oxc-project/oxc/releases)
- [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxfmt/CHANGELOG.md)
- [Commits](https://github.com/oxc-project/oxc/commits/oxfmt_v0.37.0/npm/oxfmt)

Updates `oxlint` from 1.51.0 to 1.52.0
- [Release notes](https://github.com/oxc-project/oxc/releases)
- [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxlint/CHANGELOG.md)
- [Commits](https://github.com/oxc-project/oxc/commits/oxlint_v1.52.0/npm/oxlint)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 25.4.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development
- dependency-name: lint-staged
  dependency-version: 16.3.3
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development
- dependency-name: oxfmt
  dependency-version: 0.37.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development
- dependency-name: oxlint
  dependency-version: 1.52.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@vincentkoc vincentkoc merged commit 25256c8 into openclaw:main Mar 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants